From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 9D9C2FFA for ; Mon, 8 Jun 2015 22:25:06 +0200 (CEST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E5CD98E501 for ; Mon, 8 Jun 2015 20:25:05 +0000 (UTC) Received: from tfherb-2.local (vpn-61-146.rdu2.redhat.com [10.10.61.146]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t58KP5HB004886 for ; Mon, 8 Jun 2015 16:25:05 -0400 Message-ID: <5575FA21.5060700@redhat.com> Date: Mon, 08 Jun 2015 16:25:05 -0400 From: Thomas F Herbert Organization: Red Hat User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: dev@dpdk.org References: <1433209800-29091-1-git-send-email-huawei.xie@intel.com> <1433474786-704-1-git-send-email-huawei.xie@intel.com> <74F120C019F4A64C9B78E802F6AD4CC220567AC8@IRSMSX106.ger.corp.intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Subject: Re: [dpdk-dev] [PATCH v2] vhost: provide vhost API to unregister vhost unix domain socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2015 20:25:06 -0000 On 6/8/15 11:38 AM, Xie, Huawei wrote: > On 6/5/2015 5:04 PM, Loftus, Ciara wrote: >> >>> -----Original Message----- >>> From: Xie, Huawei >>> Sent: Friday, June 05, 2015 4:26 AM >>> To: dev@dpdk.org >>> Cc: Loftus, Ciara; Xie, Huawei; Sun, Peng A >>> Subject: [PATCH v2] vhost: provide vhost API to unregister vhost unix domain >>> socket >>> >>> rte_vhost_driver_unregister will remove the listenfd from event list, and >>> then close it. >>> >>> Signed-off-by: Huawei Xie >>> Signed-off-by: Peng Sun >>> --- >>> lib/librte_vhost/rte_virtio_net.h | 3 ++ >>> lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 9 ++++ >>> lib/librte_vhost/vhost_user/vhost-net-user.c | 68 >>> +++++++++++++++++++++++----- >>> lib/librte_vhost/vhost_user/vhost-net-user.h | 2 +- >>> 4 files changed, 69 insertions(+), 13 deletions(-) >>> >>> >> Acked-by: Ciara Loftus >> >> >> > Thomas: > Comments to this patch? After reading the patch, it looks straight forward. I want to compile and run OVS/DPDK with vhost-user patch linked with DPDK with this patch applied first. I will respond when that is complete. > This patch will remove the socket file and associated listen fd. > In future, I would also look at whether there is opportunity to attach a > id to each vhost user net interface from QEMU. > Currently DPDK OVS creates a socket file for each virtio device and use > the file path as the id for the port. > > /huawei > >