Re: [dpdk-dev] [PATCH] dpdk1.7.1 rte.app.mk add options not not build targerts

[Maxim Uvarov <maxim.uvarov@linaro.org>]

On 06/09/15 15:05, Olivier MATZ wrote:
> Hello Maxim,
>
> On 06/09/2015 12:15 PM, Maxim Uvarov wrote:
>> Inherit build varibles only so that this file can be included
>> from other projects.
>>
>> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
>
> Can you detail a bit more what you want to do?
> Why do you need to include rte.app.mk? This file is
> internal to the dpdk framework.
>
> By the way, the title is not understandable:
> - why dpdk1.7.1 ?
> - targerts -> targets
> - not not ?
>
> Regards,
> Olivier

Sorry it was quick patch, some typos there. I intended to discuss the 
idea of what I need and might it it's useful for others.
I did ODP implementation with dpdk as back end. And staid on v1.7.1. But 
that patch should be good for the latest git,
if not I can update it.

So my environment is: I build library which calls dpdk functions. That 
library is used to build applications. I need to steal CFLAGS, LDFLAGS,
and build script from dpdk for my library and example apps. So I just 
point where dpdk is and my library build system should inherit the same
env which dpdk used. One reason is optimization and second reason is to 
compile in dpdk PMD drivers the same way as dpdk does that.

So in my Makefile I do: include $dpdk/mk/rte.app.mk

Is that needed for somebody else?

Thanks,
Maxim.

>
>
>> ---
>>   mk/rte.app.mk | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index 34dff2a..b75925d 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -222,6 +222,7 @@ endif # ifeq ($(NO_AUTOLIBS),)
>>
>>   LDLIBS += $(CPU_LDLIBS)
>>
>> +ifneq ($(DPRK_APP_MK_SKIP_BUILD_TARGETS),1)
>>   .PHONY: all
>>   all: install
>>
>> @@ -232,6 +233,7 @@ _postinstall: build
>>
>>   .PHONY: build
>>   build: _postbuild
>> +endif
>>
>>   exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))
>>
>> @@ -306,6 +308,7 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP)
>>       @[ -d $(RTE_OUTPUT)/app ] || mkdir -p $(RTE_OUTPUT)/app
>>       $(Q)cp -f $(APP).map $(RTE_OUTPUT)/app
>>
>> +ifneq ($(DPRK_APP_MK_SKIP_BUILD_TARGETS), 1)
>>   #
>>   # Clean all generated files
>>   #
>> @@ -317,7 +320,7 @@ clean: _postclean
>>   doclean:
>>       $(Q)rm -rf $(APP) $(OBJS-all) $(DEPS-all) $(DEPSTMP-all) \
>>         $(CMDS-all) $(INSTALL-FILES-all) .$(APP).cmd
>> -
>> +endif
>>
>>   include $(RTE_SDK)/mk/internal/rte.compile-post.mk
>>   include $(RTE_SDK)/mk/internal/rte.install-post.mk
>>
>