From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 7EF50DE6 for ; Tue, 9 Jun 2015 14:59:53 +0200 (CEST) Received: by wgbgq6 with SMTP id gq6so12731565wgb.3 for ; Tue, 09 Jun 2015 05:59:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=b5Pj4xfAYhmeo5iaOgey3owKOLwRfk/gDNNwWsj0AIw=; b=e9HNWDXypOqHLnjP+oLOfl11S8rHP/piSO7fS/4WIpH6g1IrU3+HzNovfRlJnPVElG 42scfFPIDao+fMiLC0nQ+3xCl6Md7MW9ahffSJKLMrHWBIAqK8HOvHPM1rYcdp9vB7c2 zggjG2m5sB5LS1f0B9eaCkNtmeu7WpcwgOPEDA9kJzMSAtay7Bj4V0vTLENz2d+etzBw 61X2HazL7GXJoFdKHovhrFyUrkjvy5kgQUZpQgyp8oPONFgOfVu8SYtddWXiW2vLmp+M 0qxfXLXicOcfbWu91Zm9rYippxRu5hVGwN30Sq1n9kc2f6ebBoh/Eu/4TIGa2m1oz0sI QAjg== X-Gm-Message-State: ALoCoQkiOzXr/QfOhNFEpigQBlf5gLtjwgnQ5wvRvsfQQT/QRMf4IJVXh32OP5Ym9nqQ1PM9gW2N X-Received: by 10.194.189.80 with SMTP id gg16mr42560202wjc.9.1433854789968; Tue, 09 Jun 2015 05:59:49 -0700 (PDT) Received: from [192.168.1.34] ([87.120.178.39]) by mx.google.com with ESMTPSA id i6sm9340132wjf.29.2015.06.09.05.59.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jun 2015 05:59:49 -0700 (PDT) Message-ID: <5576E343.9050309@linaro.org> Date: Tue, 09 Jun 2015 15:59:47 +0300 From: Maxim Uvarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Olivier MATZ , dev@dpdk.org References: <1433844953-29887-1-git-send-email-maxim.uvarov@linaro.org> <5576D68F.7040804@6wind.com> In-Reply-To: <5576D68F.7040804@6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] dpdk1.7.1 rte.app.mk add options not not build targerts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 12:59:53 -0000 On 06/09/15 15:05, Olivier MATZ wrote: > Hello Maxim, > > On 06/09/2015 12:15 PM, Maxim Uvarov wrote: >> Inherit build varibles only so that this file can be included >> from other projects. >> >> Signed-off-by: Maxim Uvarov > > Can you detail a bit more what you want to do? > Why do you need to include rte.app.mk? This file is > internal to the dpdk framework. > > By the way, the title is not understandable: > - why dpdk1.7.1 ? > - targerts -> targets > - not not ? > > Regards, > Olivier Sorry it was quick patch, some typos there. I intended to discuss the idea of what I need and might it it's useful for others. I did ODP implementation with dpdk as back end. And staid on v1.7.1. But that patch should be good for the latest git, if not I can update it. So my environment is: I build library which calls dpdk functions. That library is used to build applications. I need to steal CFLAGS, LDFLAGS, and build script from dpdk for my library and example apps. So I just point where dpdk is and my library build system should inherit the same env which dpdk used. One reason is optimization and second reason is to compile in dpdk PMD drivers the same way as dpdk does that. So in my Makefile I do: include $dpdk/mk/rte.app.mk Is that needed for somebody else? Thanks, Maxim. > > >> --- >> mk/rte.app.mk | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk >> index 34dff2a..b75925d 100644 >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -222,6 +222,7 @@ endif # ifeq ($(NO_AUTOLIBS),) >> >> LDLIBS += $(CPU_LDLIBS) >> >> +ifneq ($(DPRK_APP_MK_SKIP_BUILD_TARGETS),1) >> .PHONY: all >> all: install >> >> @@ -232,6 +233,7 @@ _postinstall: build >> >> .PHONY: build >> build: _postbuild >> +endif >> >> exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1)))) >> >> @@ -306,6 +308,7 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP) >> @[ -d $(RTE_OUTPUT)/app ] || mkdir -p $(RTE_OUTPUT)/app >> $(Q)cp -f $(APP).map $(RTE_OUTPUT)/app >> >> +ifneq ($(DPRK_APP_MK_SKIP_BUILD_TARGETS), 1) >> # >> # Clean all generated files >> # >> @@ -317,7 +320,7 @@ clean: _postclean >> doclean: >> $(Q)rm -rf $(APP) $(OBJS-all) $(DEPS-all) $(DEPSTMP-all) \ >> $(CMDS-all) $(INSTALL-FILES-all) .$(APP).cmd >> - >> +endif >> >> include $(RTE_SDK)/mk/internal/rte.compile-post.mk >> include $(RTE_SDK)/mk/internal/rte.install-post.mk >> >