From: Panu Matilainen <pmatilai@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] rte_ring: remove deprecated functions
Date: Fri, 12 Jun 2015 08:46:55 +0300 [thread overview]
Message-ID: <557A724F.5090801@redhat.com> (raw)
In-Reply-To: <1434086314-14371-2-git-send-email-stephen@networkplumber.org>
On 06/12/2015 08:18 AM, Stephen Hemminger wrote:
> From: Stephen Hemminger <shemming@brocade.com>
>
> These were deprecated in 2.0 so remove them from 2.1
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/ring/rte_eth_ring.c | 55 -------------------------------
> drivers/net/ring/rte_eth_ring_version.map | 2 --
> 2 files changed, 57 deletions(-)
>
[...]
> diff --git a/drivers/net/ring/rte_eth_ring_version.map b/drivers/net/ring/rte_eth_ring_version.map
> index 8ad107d..0875e25 100644
> --- a/drivers/net/ring/rte_eth_ring_version.map
> +++ b/drivers/net/ring/rte_eth_ring_version.map
> @@ -2,8 +2,6 @@ DPDK_2.0 {
> global:
>
> rte_eth_from_rings;
> - rte_eth_ring_pair_attach;
> - rte_eth_ring_pair_create;
>
> local: *;
> };
Removing symbols is an ABI break so it additionally requires a soname
bump for this library.
In addition, simply due to being the first library to do so, it'll also
then break the combined shared library as is currently is. Mind you,
this is not an objection at all, the need to change to a linker script
approach has always been a matter of time.
- Panu -
next prev parent reply other threads:[~2015-06-12 5:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 5:18 [dpdk-dev] [PATCH 0/3] do deprecation in 2.1 Stephen Hemminger
2015-06-12 5:18 ` [dpdk-dev] [PATCH 1/3] rte_ring: remove deprecated functions Stephen Hemminger
2015-06-12 5:46 ` Panu Matilainen [this message]
2015-06-12 14:00 ` Bruce Richardson
2015-06-12 14:15 ` Thomas Monjalon
2015-06-12 14:22 ` Bruce Richardson
2015-06-12 5:18 ` [dpdk-dev] [PATCH 2/3] kni: " Stephen Hemminger
2015-06-12 6:20 ` Panu Matilainen
2015-06-15 2:35 ` Zhang, Helin
2015-06-12 5:18 ` [dpdk-dev] [PATCH 3/3] acl: mark " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557A724F.5090801@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).