From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 57A8B2E8A for ; Fri, 12 Jun 2015 07:46:57 +0200 (CEST) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 941052F14B2; Fri, 12 Jun 2015 05:46:56 +0000 (UTC) Received: from localhost.localdomain (vpn1-4-97.ams2.redhat.com [10.36.4.97]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5C5ktoi031752; Fri, 12 Jun 2015 01:46:55 -0400 Message-ID: <557A724F.5090801@redhat.com> Date: Fri, 12 Jun 2015 08:46:55 +0300 From: Panu Matilainen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Hemminger , dev@dpdk.org References: <1434086314-14371-1-git-send-email-stephen@networkplumber.org> <1434086314-14371-2-git-send-email-stephen@networkplumber.org> In-Reply-To: <1434086314-14371-2-git-send-email-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Cc: Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 1/3] rte_ring: remove deprecated functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2015 05:46:57 -0000 On 06/12/2015 08:18 AM, Stephen Hemminger wrote: > From: Stephen Hemminger > > These were deprecated in 2.0 so remove them from 2.1 > > Signed-off-by: Stephen Hemminger > --- > drivers/net/ring/rte_eth_ring.c | 55 ------------------------------- > drivers/net/ring/rte_eth_ring_version.map | 2 -- > 2 files changed, 57 deletions(-) > [...] > diff --git a/drivers/net/ring/rte_eth_ring_version.map b/drivers/net/ring/rte_eth_ring_version.map > index 8ad107d..0875e25 100644 > --- a/drivers/net/ring/rte_eth_ring_version.map > +++ b/drivers/net/ring/rte_eth_ring_version.map > @@ -2,8 +2,6 @@ DPDK_2.0 { > global: > > rte_eth_from_rings; > - rte_eth_ring_pair_attach; > - rte_eth_ring_pair_create; > > local: *; > }; Removing symbols is an ABI break so it additionally requires a soname bump for this library. In addition, simply due to being the first library to do so, it'll also then break the combined shared library as is currently is. Mind you, this is not an objection at all, the need to change to a linker script approach has always been a matter of time. - Panu -