From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3AEDE5A0A for ; Fri, 12 Jun 2015 08:20:12 +0200 (CEST) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 64F558E6EC; Fri, 12 Jun 2015 06:20:11 +0000 (UTC) Received: from localhost.localdomain (vpn1-4-97.ams2.redhat.com [10.36.4.97]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5C6K9Xw014201; Fri, 12 Jun 2015 02:20:10 -0400 Message-ID: <557A7A19.2070606@redhat.com> Date: Fri, 12 Jun 2015 09:20:09 +0300 From: Panu Matilainen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Hemminger , dev@dpdk.org References: <1434086314-14371-1-git-send-email-stephen@networkplumber.org> <1434086314-14371-3-git-send-email-stephen@networkplumber.org> In-Reply-To: <1434086314-14371-3-git-send-email-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Cc: Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 2/3] kni: remove deprecated functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2015 06:20:12 -0000 On 06/12/2015 08:18 AM, Stephen Hemminger wrote: > From: Stephen Hemminger > > These functions were tagged as deprecated in 2.0 so they can be > removed in 2.1 > > Signed-off-by: Stephen Hemminger > --- > app/test/Makefile | 6 ------ > app/test/test_kni.c | 36 -------------------------------- > lib/librte_kni/rte_kni.c | 50 -------------------------------------------- > lib/librte_kni/rte_kni.h | 54 ------------------------------------------------ > 4 files changed, 146 deletions(-) > [...] > diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h > index 603e2cd..f65ce24 100644 > --- a/lib/librte_kni/rte_kni.h > +++ b/lib/librte_kni/rte_kni.h > @@ -129,30 +129,6 @@ extern struct rte_kni *rte_kni_alloc(struct rte_mempool *pktmbuf_pool, > struct rte_kni_ops *ops); > > /** > - * It create a KNI device for specific port. > - * > - * Note: It is deprecated and just for backward compatibility. > - * > - * @param port_id > - * Port ID. > - * @param mbuf_size > - * mbuf size. > - * @param pktmbuf_pool > - * The mempool for allocting mbufs for packets. > - * @param ops > - * The pointer to the callbacks for the KNI kernel requests. > - * > - * @return > - * - The pointer to the context of a KNI interface. > - * - NULL indicate error. > - */ > -extern struct rte_kni *rte_kni_create(uint8_t port_id, > - unsigned mbuf_size, > - struct rte_mempool *pktmbuf_pool, > - struct rte_kni_ops *ops) \ > - __attribute__ ((deprecated)); > - > -/** > * Release KNI interface according to the context. It will also release the > * paired KNI interface in kernel space. All processing on the specific KNI > * context need to be stopped before calling this interface. > @@ -221,21 +197,6 @@ extern unsigned rte_kni_tx_burst(struct rte_kni *kni, > struct rte_mbuf **mbufs, unsigned num); > > /** > - * Get the port id from KNI interface. > - * > - * Note: It is deprecated and just for backward compatibility. > - * > - * @param kni > - * The KNI interface context. > - * > - * @return > - * On success: The port id. > - * On failure: ~0x0 > - */ > -extern uint8_t rte_kni_get_port_id(struct rte_kni *kni) \ > - __attribute__ ((deprecated)); > - > -/** > * Get the KNI context of its name. > * > * @param name > @@ -248,21 +209,6 @@ extern uint8_t rte_kni_get_port_id(struct rte_kni *kni) \ > extern struct rte_kni *rte_kni_get(const char *name); > > /** > - * Get the KNI context of the specific port. > - * > - * Note: It is deprecated and just for backward compatibility. > - * > - * @param port_id > - * the port id. > - * > - * @return > - * On success: Pointer to KNI interface. > - * On failure: NULL > - */ > -extern struct rte_kni *rte_kni_info_get(uint8_t port_id) \ > - __attribute__ ((deprecated)); > - > -/** > * Register KNI request handling for a specified port,and it can > * be called by master process or slave process. > * > These symbols need to be removed from rte_kni_version.map too, and since its an ABI break, the library soname needs a bump as well. - Panu -