From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E00BBC874 for ; Fri, 19 Jun 2015 17:46:04 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 19 Jun 2015 08:45:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,644,1427785200"; d="scan'208";a="713992753" Received: from dwdohert-dpdk-fedora-20.ir.intel.com ([163.33.213.98]) by orsmga001.jf.intel.com with ESMTP; 19 Jun 2015 08:45:49 -0700 Message-ID: <55843ABC.6020606@intel.com> Date: Fri, 19 Jun 2015 16:52:28 +0100 From: Declan Doherty User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Hemminger References: <1433973985-17940-1-git-send-email-stephen@networkplumber.org> <1433973985-17940-3-git-send-email-stephen@networkplumber.org> In-Reply-To: <1433973985-17940-3-git-send-email-stephen@networkplumber.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 2/2] bonding: fix name and port validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 15:46:05 -0000 On 10/06/15 23:06, Stephen Hemminger wrote: > From: Stephen Hemminger > > Cleanup the code in bonding that checks ports. > * Use standard rte_eth_dev_is_valid_port > * Change name of driver string to avoid variable namespace conflicts > * Get rid of unnecessary string comparison stuff. A simple pointer > check is enough here. > * Get rid of unnecessary assignment of driver_name, it is already > done by common code. > * Don't generate unnecessary log messages on error. > > Signed-off-by: Stephen Hemminger Acked-by: Declan Doherty