From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EA212C674 for ; Tue, 23 Jun 2015 09:39:40 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 23 Jun 2015 00:39:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,664,1427785200"; d="scan'208";a="748689498" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.220.129]) ([10.237.220.129]) by fmsmga002.fm.intel.com with ESMTP; 23 Jun 2015 00:39:39 -0700 Message-ID: <55890D3A.109@intel.com> Date: Tue, 23 Jun 2015 08:39:38 +0100 From: "Gonzalez Monroy, Sergio" User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?windows-1252?Q?Simon_K=E5gstr=F6m?= , dev@dpdk.org References: <1434749378-8578-1-git-send-email-cchemparathy@ezchip.com> <5587BCE9.4000809@intel.com> <5587BFA7.2000206@netinsight.net> In-Reply-To: <5587BFA7.2000206@netinsight.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] mk: add support for gdb debug info generation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2015 07:39:41 -0000 On 22/06/2015 08:56, Simon Kågström wrote: > On 2015-06-22 09:44, Gonzalez Monroy, Sergio wrote: >> On 19/06/2015 22:29, Cyril Chemparathy wrote: >>> From: Cyril Chemparathy >>> >>> It is often useful to build with debug enabled, we add a config >>> (CONFIG_RTE_TOOLCHAIN_DEBUG) to do so. >>> >>> +ifeq ($(CONFIG_RTE_TOOLCHAIN_DEBUG),y) >>> +TOOLCHAIN_CFLAGS += -g -ggdb >>> +TOOLCHAIN_LDFLAGS += -g -ggdb >>> +endif >> I don't think you need to modify the makefiles and introduce a new >> compile time option for this. >> The same result can be easily achieved by setting EXTRA_CFLAGS in the >> command line. ie: >> $ make install T=x86_64-native-linuxapp-gcc EXTRA_CFLAGS='-g -ggdb' > Why isn't -g standard though? The binaries should/will anyhow be > stripped when used for production - but debugging information should be > useful when analysing crashes. I guess you could argue that, to always build with debug info then strip it down. You would need another flag to strip debug info for production, or leave it for debugging. In my opinion is not worth it, but it you feel strongly about it you can submit patches and let the community decide. Sergio > // Simon >