DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Campbell <aaron@arbor.net>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf
Date: Thu, 26 Jun 2014 13:20:31 -0300
Message-ID: <5590E373-EC37-4544-A983-52156CFA81E2@arbor.net> (raw)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CEF87D2@IRSMSX103.ger.corp.intel.com>

On Jun 26, 2014, at 12:09 PM, Richardson, Bruce <bruce.richardson@intel.com> wrote:

>> I agree we should try to use the "deprecated" attribute when possible.
>> So application porting effort will be smoother.
>> But in this case, there is something different: as Stephen wrote, rte_snprintf
>> is useless. It's useless inside the DPDK so it's even more useless for user
>> applications.
>> As it's really useless, it has no sense to keep it as deprecated.
>> Please, let's simply remove it.
> The reason to keep it as deprecated is so that those customers who don't want to do a huge amount of search-replace immediately can get things working again temporarily using -Wno-deprecated. It provides a simple temporary fallback cushion, and then we can completely remove the function later. 
> So, I'd like to see us remove all our usage of the function internally in 1.7, along with marking as deprecated, and then completely remove in 1.8, (i.e. in a week's time or so) :-)

As a DPDK user, I’d vote to kill it now.  I doubt it is widely used in any external applications.  Such usage would be mostly from copy/pasting the sample code, is my guess.


  reply	other threads:[~2014-06-26 16:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 16:02 Stephen Hemminger
2014-06-24 16:03 ` [dpdk-dev] [PATCH 2/3] test: remove no longer valid tests Stephen Hemminger
2014-06-24 16:05 ` [dpdk-dev] [PATCH 3/3] fix incorrect snprintf usage Stephen Hemminger
2014-06-24 17:39 ` [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf Richardson, Bruce
2014-06-24 17:54   ` Stephen Hemminger
2014-06-24 18:00     ` Richardson, Bruce
2014-06-25  7:55       ` Olivier MATZ
2014-06-25  8:33   ` Thomas Monjalon
2014-06-26 15:09     ` Richardson, Bruce
2014-06-26 16:20       ` Aaron Campbell [this message]
2014-06-27  0:37         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5590E373-EC37-4544-A983-52156CFA81E2@arbor.net \
    --to=aaron@arbor.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git