From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id DD6396AB7 for ; Fri, 20 Jun 2014 16:16:14 +0200 (CEST) Received: by mail-wi0-f172.google.com with SMTP id hi2so895345wib.5 for ; Fri, 20 Jun 2014 07:16:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5u/kHYHjmCeGJiKblaGwIvVhdTOI62IbGpue27cbfAY=; b=iK2MDcEMAwUXoRtNWCcrK8cOVUWCG5L22p+j0iKwMYhrZ4KGIi1KoQtqxYULinUVCM BlyK/3nef1n1XZYfLL3SnGB81MfS1FqIfx2Xphxd1bPTbjUF+Hz3/hlqGgTGIA6S1/G3 pn+3l6h3nArx5n2jEbYIkLbI0gLeMGFF2dOSPa9TevReVEWccrR37lVoibiEdFVVqicG 0rNMNAfizHz+NXb0gmkazdeUXyYHfl1+kuTf0E2uB7xUCEyoMNVif2hFf3vvxdAblYwK aL0nqjZa3Zn/ut4LPxNsIXIq+Cmb6VPt79YwRZHLEm/qsb6s0XafQAVKiQBkz73SRbck CJdw== X-Gm-Message-State: ALoCoQmOdu5NXF63pv4Qvia9IZPQAMrRHDYymPfnNiBtDBzVECEnggyfAdLLUo3+Mhql6qJXhEei X-Received: by 10.194.24.36 with SMTP id r4mr1642965wjf.35.1403273789785; Fri, 20 Jun 2014 07:16:29 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id fb15sm5102714wid.23.2014.06.20.07.16.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jun 2014 07:16:29 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Fri, 20 Jun 2014 16:16:26 +0200 Message-ID: <5591358.CZJT0GNYNp@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1403244889-21358-4-git-send-email-helin.zhang@intel.com> References: <1403244889-21358-1-git-send-email-helin.zhang@intel.com> <1403244889-21358-4-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/7] i40e: ignore the failure of updating default filter settings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jun 2014 14:16:15 -0000 2014-06-20 14:14, Helin Zhang: > The failure of updating the default filter setting should be > ignored. The updating is to change the default vlan filter > behaviours configured by firmware to expected. > The failure happens on the firmware version of 4.2.2, > while doesn't happen on previous versions, as the default > settings of firmware changed. [...] > ret = i40e_update_default_filter_setting(vsi); > - if (ret != I40E_SUCCESS) { > - PMD_DRV_LOG(ERR, "Failed to remove default " > - "filter setting\n"); > - goto fail_msix_alloc; > - } > - } > - else if (type == I40E_VSI_SRIOV) { > + if (ret != I40E_SUCCESS) > + PMD_DRV_LOG(ERR, "Failure of removing default filter " > + "setting can be ignored\n"); > + /** > + * The failure of updating default filter setting > + * can be ignored > + */ > + } else if (type == I40E_VSI_SRIOV) { The log is not clear and the log message doesn't include firmware explanation. Please reword. By the way, there is already a log message in the function: PMD_DRV_LOG(WARNING, "Failed to remove default [mac,vlan] config\n"); http://dpdk.org/browse/dpdk/commit/?id=9d7d8513b587d32b8f66 Will we see these error messages each time we configure an i40e device? I think it's strange to have a log message saying it can be ignored. Can it be a real error in some cases? -- Thomas