From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id B4DB7B38D for ; Tue, 30 Jun 2015 04:32:01 +0200 (CEST) Received: by pabvl15 with SMTP id vl15so114446311pab.1 for ; Mon, 29 Jun 2015 19:32:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=RA2n1PhoC5Wt3+AOY7Xnkp5CIKggE387wem55iTYxVo=; b=Bd1tb83DCQM3gRqHuYJzIuv5drMIWhMGzYpiTUG9LZxHPtmSRleDo+Ytb3FWZct55M 74uWU9VWOMD1mrva3s0u89o7ntMKIOwHOWkKcSgOF/Su6WQGsNC7Y6pvrRC/eNwBbzJs 8Zmo9w6bbv9lsy1Oelw7qWDYtfGzGe30mA+WA8ZT7nBlaM/c7HFtBORvxGRfAutGI572 Knpnk2w8I7FQH3OPLG8V5SPx/4OcNQND7bHtszTOY0xBDy3zwOX+TGembxt4CD1wmk4B se6kp/1vu02j6RVS6XYhUgESoP+m8EkoLniPceilw8eq402Sw375X3Vi6hZ13cy/M1f9 CKlQ== X-Gm-Message-State: ALoCoQnCPGlsL118ELRYmc5VJJ9tKxtsPQuwGNwwxgNcZuo3RVM6eX+UiRq3OJ2y6vCc5QZabXQG X-Received: by 10.66.63.9 with SMTP id c9mr38044152pas.40.1435631521096; Mon, 29 Jun 2015 19:32:01 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id fc3sm43791966pab.16.2015.06.29.19.31.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 19:32:00 -0700 (PDT) Message-ID: <5591FF9E.7030102@igel.co.jp> Date: Tue, 30 Jun 2015 11:31:58 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Iremonger, Bernard" , "dev@dpdk.org" References: <1432016513-8456-5-git-send-email-mukawa@igel.co.jp> <1435546610-4533-1-git-send-email-mukawa@igel.co.jp> <1435546610-4533-2-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C204A42D4B@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C204A42D4B@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/8] eal: Add pci_uio_alloc_uio_resource() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2015 02:32:02 -0000 On 2015/06/29 22:24, Iremonger, Bernard wrote: > >> -----Original Message----- >> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] >> Sent: Monday, June 29, 2015 3:57 AM >> To: dev@dpdk.org >> Cc: Iremonger, Bernard; david.marchand@6wind.com; Tetsuya.Mukawa >> Subject: [PATCH v3 1/8] eal: Add pci_uio_alloc_uio_resource() >> >> From: "Tetsuya.Mukawa" >> >> This patch adds a new function called pci_uio_alloc_uio_resource(). >> The function hides how to prepare uio resource in linuxapp and bsdapp. >> With the function, pci_uio_map_resource() will be more abstracted. >> >> Signed-off-by: Tetsuya Mukawa > Hi Tetsuya, > > There are two comments inline below. > >> --- >> lib/librte_eal/bsdapp/eal/eal_pci.c | 70 +++++++++++++++++++--------- >> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 77 ++++++++++++++++++++++--- >> ------ >> 2 files changed, 104 insertions(+), 43 deletions(-) >> >> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c >> b/lib/librte_eal/bsdapp/eal/eal_pci.c >> index 06c564f..2d9f3a5 100644 >> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c >> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c >> @@ -189,28 +189,17 @@ pci_uio_map_secondary(struct rte_pci_device >> *dev) >> return 1; >> } >> >> -/* map the PCI resource of a PCI device in virtual memory */ static int - >> pci_uio_map_resource(struct rte_pci_device *dev) >> +pci_uio_alloc_uio_resource(struct rte_pci_device *dev, >> + struct mapped_pci_resource **uio_res) > The name of this function is a bit longwinded, pci_uio_alloc_resource() might be better. Hi Bernard, Thanks for comments. Sure I will fix it. >> >> -/* map the PCI resource of a PCI device in virtual memory */ -int - >> pci_uio_map_resource(struct rte_pci_device *dev) >> +static int >> +pci_uio_alloc_uio_resource(struct rte_pci_device *dev, >> + struct mapped_pci_resource **uio_res) > The name of this function is a bit longwinded, pci_uio_alloc_resource() might be better. Also, I will fix above. Regards, Tetsuya