From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id 00481C41C for ; Tue, 30 Jun 2015 10:08:44 +0200 (CEST) Received: by pdbci14 with SMTP id ci14so1895105pdb.2 for ; Tue, 30 Jun 2015 01:08:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Y5O0ydoZtIdL5oQhVXcgRY5eM/Pqc1nlPTOV34tEh1E=; b=BPOgdB8xgwV50jQSq96a97xNA0yc5qMmpoEVqaqcA3kItIZL2PxJbRyHIMU2h9D/yO afVxPpFH46sJ3zhi21z8JeBQRxEtHUDogL7vfS6cDWdNcXXOPvJDHWHE+NEIKmp95Svz tQorx/J2+uG/TeY7uDAxPlkltPL22eAvdl53MiBa4TjfEJYzl9bDjttq1m2Vcs4v88/e qclSXO+GkpVM99cIok+mQB34gcoNIvGMcxxwYHZZlGlS2E6bUF6sPZaihHrAukv/yGru j7JsgyDBwEv0NoS9wpJPteVJqicjERcU5irA4bX5/be8tNmXWGQonyx2zf1akFZn+Y0l rM+Q== X-Gm-Message-State: ALoCoQkRhmDpjhWvOiLkwUUQs4clewRmt0zSXCEhVNx3Xzd8MUw+85VbkF4U4wQubieMw/qZpS3M X-Received: by 10.68.169.34 with SMTP id ab2mr40423301pbc.120.1435651724096; Tue, 30 Jun 2015 01:08:44 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id ox6sm44677359pdb.25.2015.06.30.01.08.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jun 2015 01:08:43 -0700 (PDT) Message-ID: <55924E89.6010705@igel.co.jp> Date: Tue, 30 Jun 2015 17:08:41 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bruce Richardson References: <1432016513-8456-5-git-send-email-mukawa@igel.co.jp> <1435546610-4533-1-git-send-email-mukawa@igel.co.jp> <1435546610-4533-5-git-send-email-mukawa@igel.co.jp> <20150629152837.GA3260@bricha3-MOBL3> In-Reply-To: <20150629152837.GA3260@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 4/8] eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and bsdapp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jun 2015 08:08:45 -0000 On 2015/06/30 0:28, Bruce Richardson wrote: > On Mon, Jun 29, 2015 at 11:56:46AM +0900, Tetsuya Mukawa wrote: >> From: "Tetsuya.Mukawa" >> >> This patch consolidates below functions, and implements these in common >> eal code. >> - rte_eal_pci_probe_one_driver() >> - rte_eal_pci_close_one_driver() >> >> Because pci_map_device() is only implemented in linuxapp, the patch >> implements it in bsdapp too. This implemented function will be merged to >> linuxapp one with later patch. >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_eal/bsdapp/eal/eal_pci.c | 74 ++--------------- >> lib/librte_eal/common/eal_common_pci.c | 129 ++++++++++++++++++++++++++++ >> lib/librte_eal/common/eal_private.h | 21 ++--- >> lib/librte_eal/linuxapp/eal/eal_pci.c | 148 ++------------------------------- >> 4 files changed, 153 insertions(+), 219 deletions(-) >> >> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c >> index c7017eb..2a623e3 100644 >> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c >> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c >> @@ -88,7 +88,7 @@ static struct rte_tailq_elem rte_uio_tailq = { >> EAL_REGISTER_TAILQ(rte_uio_tailq) >> >> /* unbind kernel driver for this device */ >> -static int >> +int >> pci_unbind_kernel_driver(struct rte_pci_device *dev __rte_unused) >> { >> RTE_LOG(ERR, EAL, "RTE_PCI_DRV_FORCE_UNBIND flag is not implemented " >> @@ -430,6 +430,13 @@ skipdev: >> return 0; >> } >> >> +/* Map pci device */ >> +int >> +pci_map_device(struct rte_pci_device *dev) >> +{ >> + return pci_uio_map_resource(dev); >> +} >> + > These lines are added here, but removed again in the next patch in the series. > Though not wrong, per-se, it just seems untidy. Perhaps the patchset order needs > to be changed somewhat? > > /Bruce Hi Bruce, I appreciate your comment. Sure, I will change the order of these patches. Could you please check patches I will send later? Regards, Tetsuya