From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 460FDC344 for ; Wed, 1 Jul 2015 08:37:30 +0200 (CEST) Received: by pdjd13 with SMTP id d13so20219464pdj.0 for ; Tue, 30 Jun 2015 23:37:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=L+GSvZhIePH55BnSNCbHhM6wnTGrfDls7Iv2TnN4T1M=; b=VuSW3x8VUp00ckq4bPU0iNyA3wTOq5d4Wum275yVP91aqo4HviIJXxCTNUFnsW+x0u Y5cem71WQmMfPXAJm+YNs5+vP9FqEjoT8q+hw4q/0KNzqb+H17e94UWnnLDgcf9NhXtN C05Djn964lbJYSPYKcJGOwHgI2DNAk9MH2Rl5qk9TyrLSU1lKLKj81zinkntUIjAouPX Vv3hoY/V3bzcrJBK9z00U74h47M/vUAgjuEkNbxp2XdSM87lM6k5l1rMyarXFSbGBDeG bU4SuMrv7EB2xNfplDWeliSH0G50hKYld+UrrGZ6WjxuUFu6EpDzRoPny8ZIqP/VKAh3 BERw== X-Gm-Message-State: ALoCoQlT13ef4tosbSv3oWcuytPEHCXVp6VVmTUoEVx9bL0V2JWSUJdTsCsKqpdI0LeXqgkSff5Y X-Received: by 10.68.104.97 with SMTP id gd1mr51054446pbb.15.1435732649874; Tue, 30 Jun 2015 23:37:29 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id km11sm953674pbd.61.2015.06.30.23.37.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jun 2015 23:37:28 -0700 (PDT) Message-ID: <55938AA6.9050206@igel.co.jp> Date: Wed, 01 Jul 2015 15:37:26 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bruce Richardson , "Iremonger, Bernard" References: <1435546610-4533-9-git-send-email-mukawa@igel.co.jp> <1435652811-3487-1-git-send-email-mukawa@igel.co.jp> <1435652811-3487-2-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C204A435E7@IRSMSX108.ger.corp.intel.com> <20150630154011.GA6680@bricha3-MOBL3> In-Reply-To: <20150630154011.GA6680@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4] eal: Enable Port Hotplug as default in Linux and BSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2015 06:37:30 -0000 On 2015/07/01 0:40, Bruce Richardson wrote: > On Tue, Jun 30, 2015 at 04:08:08PM +0100, Iremonger, Bernard wrote: >>> -----Original Message----- >>> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] >>> Sent: Tuesday, June 30, 2015 9:27 AM >>> To: dev@dpdk.org >>> Cc: Iremonger, Bernard; david.marchand@6wind.com; Richardson, Bruce; >>> Tetsuya.Mukawa >>> Subject: [PATCH v4] eal: Enable Port Hotplug as default in Linux and BSD >>> >>> From: "Tetsuya.Mukawa" >>> >>> This patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option, and enables >>> it as default in both Linux and BSD. >>> Also, to support port hotplug, rte_eal_pci_scan() and below missing symbols >>> should be exported to ethdev library. >>> - rte_eal_parse_devargs_str() >>> - rte_eal_pci_close_one() >>> - rte_eal_pci_probe_one() >>> - rte_eal_pci_scan() >>> - rte_eal_vdev_init() >>> - rte_eal_vdev_uninit() >>> >>> Signed-off-by: Tetsuya Mukawa >> Hi Tetsuya, >> >> Would it be cleaner to add this patch to the [PATCH v7 12/12] patch set as patch 13 rather than having it as a separate patch? >> > The other patch set is cleanup, merging BSD and Linuxapp code, so I think it's > best kept as a separate set. New features I'd suggest keeping separate from > cleanup. > That being said, it is only one patch, so it probably doesn't matter much either > way. :-) > > /Bruce Thanks for commenting. Let's keep separating. It will be easy for me to write cover-letter of the patch series. Regards, Tetsuya