From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id 5C0C15A59 for ; Fri, 3 Jul 2015 10:52:33 +0200 (CEST) Received: by pdcu2 with SMTP id u2so61429046pdc.3 for ; Fri, 03 Jul 2015 01:52:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=SVGUSx/BLBQ7ESKQAO9G5XQErW2AZm5EPrs8bRYky6A=; b=R4gOADS3smLyIxc5valD0uwdlN4q7ufmtVuHznvOFsQveoSxx94bmPUBMNjkqAGnjB Zcljw8f8YpzRYKMMhmsusxvhpnZFWXc85r072HCIV0qyk8+tpmh0syCdBHK3m7RO1kl+ wYLHAvOnN0y+ksPleY/g6PwnGw7VvjTQugUTXRKRVCc6hKtVgtO86BiQtkg7555c7uUg S4AY6pfkEVhHrFO/rPDKKlLSBaqZfHaQF2NP5ijVkXtaM8cayl49pDlHu06plqZW/7tV jLT8/Mte88J3+i6+0w0Q2OuRUZdUj69rdnaluvBPNPetpzTJQf2pd5YoULtyZflJAu0N JEdw== X-Gm-Message-State: ALoCoQnkmL4nilPXCi4Usuj4+stu/9sYwHyLn+XYwlzrErFRR04vKNdBLKx3noLRpItoLE7TFxFk X-Received: by 10.70.44.199 with SMTP id g7mr74758742pdm.27.1435913552823; Fri, 03 Jul 2015 01:52:32 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id r9sm8275733pdp.5.2015.07.03.01.52.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jul 2015 01:52:32 -0700 (PDT) Message-ID: <55964D4F.6030306@igel.co.jp> Date: Fri, 03 Jul 2015 17:52:31 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bruce Richardson References: <1435306705-11645-4-git-send-email-mukawa@igel.co.jp> <1435652668-3380-1-git-send-email-mukawa@igel.co.jp> <1435652668-3380-10-git-send-email-mukawa@igel.co.jp> <20150702111109.GD3828@bricha3-MOBL3> In-Reply-To: <20150702111109.GD3828@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 09/12] eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2015 08:52:33 -0000 On 2015/07/02 20:11, Bruce Richardson wrote: > On Tue, Jun 30, 2015 at 05:24:25PM +0900, Tetsuya Mukawa wrote: >> From: "Tetsuya.Mukawa" >> >> The patch consolidates below functions, and implemented in common >> eal code. >> - pci_map_resource() >> - pci_unmap_resource() >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_eal/bsdapp/eal/eal_pci.c | 22 ---------------- >> lib/librte_eal/common/eal_common_pci.c | 39 ++++++++++++++++++++++++++++ >> lib/librte_eal/common/include/rte_pci.h | 11 ++++++++ >> lib/librte_eal/linuxapp/eal/eal_pci.c | 41 ------------------------------ >> lib/librte_eal/linuxapp/eal/eal_pci_init.h | 5 ---- >> 5 files changed, 50 insertions(+), 68 deletions(-) >> > >> diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h >> index 0a2ef09..56dcb46 100644 >> --- a/lib/librte_eal/common/include/rte_pci.h >> +++ b/lib/librte_eal/common/include/rte_pci.h >> @@ -364,6 +364,17 @@ int rte_eal_pci_scan(void); >> */ >> int rte_eal_pci_probe(void); >> >> +/** >> + * Map pci resouce. >> + */ >> +void *pci_map_resource(void *requested_addr, int fd, off_t offset, >> + size_t size, int additional_flags); >> + >> +/** >> + * Map pci resouce. >> + */ >> +void pci_unmap_resource(void *requested_addr, size_t size); >> + > These functions should probably be marked "@internal", right? Yes, it should be. I will fix it. Tetsuya