From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id 37D535A5D for ; Wed, 8 Jul 2015 04:43:02 +0200 (CEST) Received: by pdrg1 with SMTP id g1so5085230pdr.2 for ; Tue, 07 Jul 2015 19:43:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=+n4fezNzXzVATBGmKfchtboGXsfMMW1/uj0R+PdZ798=; b=FHFtoa7DC/KT8e58ujdDc2i9BDLR3Ineu7Q/E+NdqlspVcLTBJPYvNG7losG8bhFAI OD1zwjq9aG2FdLs3+wkyaxZU1IPnsRwXW0xcM3Sul9gzn4U2mX4x0l3DCAUwJGLS3AZK ccGKoIoA3EgBCUH39nKTRFS0sLgmmzOa37eWeaGX6sldFRR8czI1TfjJ5NgZeDM3Iy1r jskdTwMplyVSJT1LDkf6/7edMIh7ReOC+AW5pvKsJoTr7CQ40FFCZhfPcRZviBhcD7o4 ckRWcqb2txTwv+KvRoQkTQ6NM4fH3PDuPCRZKi7dWgxL5alvmKTTJmZDsefTWdnmkK0N jiNw== X-Gm-Message-State: ALoCoQnV4Ty/9ylrHrW3ZbN1tGS1XmnNWsRD13Rgngjcb2CoJdPJBZem94+znKjyrEu7nRUU/9jM X-Received: by 10.70.22.235 with SMTP id h11mr15277413pdf.135.1436323381633; Tue, 07 Jul 2015 19:43:01 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id vx5sm529088pbc.59.2015.07.07.19.42.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jul 2015 19:43:01 -0700 (PDT) Message-ID: <559C8E32.3070808@igel.co.jp> Date: Wed, 08 Jul 2015 11:42:58 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Marchand References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp> <1436163861-3025-1-git-send-email-mukawa@igel.co.jp> <1436163861-3025-12-git-send-email-mukawa@igel.co.jp> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v8 11/12] eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 02:43:02 -0000 On 2015/07/07 17:06, David Marchand wrote: > On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa > wrote: > > From: "Tetsuya.Mukawa" > > > The patch consolidates below functions, and implemented in common > eal code. > - pci_map_device() > - pci_unmap_device() > > Signed-off-by: Tetsuya Mukawa > > --- > lib/librte_eal/bsdapp/eal/eal_pci.c | 3 ++ > lib/librte_eal/common/eal_common_pci.c | 57 > +++++++++++++++++++++++++++++++++ > lib/librte_eal/common/eal_private.h | 19 +++++++++++ > lib/librte_eal/common/include/rte_pci.h | 1 + > lib/librte_eal/linuxapp/eal/eal_pci.c | 53 > ------------------------------ > lib/librte_ether/rte_ethdev.c | 2 ++ > 6 files changed, 82 insertions(+), 53 deletions(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c > b/lib/librte_eal/bsdapp/eal/eal_pci.c > index f85fc1e..a27dca3 100644 > --- a/lib/librte_eal/bsdapp/eal/eal_pci.c > +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c > @@ -240,6 +240,9 @@ pci_scan_one(int dev_pci_fd, struct pci_conf > *conf) > /* FreeBSD has no NUMA support (yet) */ > dev->numa_node = 0; > > + /* FreeBSD has only one pass through driver */ > + dev->kdrv = RTE_KDRV_NIC_UIO; > + > > > Do we need a new define for this ? > > I know this is not really part of this patchset, but this kdrv should > just disappear. Could I make sure this? It seems 'struct rte_pci_device' still has kdrv member, also my patch defines RTE_KDRV_NIC_UIO like below. --- a/lib/librte_eal/common/include/rte_pci.h +++ b/lib/librte_eal/common/include/rte_pci.h @@ -149,6 +149,7 @@ enum rte_kernel_driver { RTE_KDRV_IGB_UIO, RTE_KDRV_VFIO, RTE_KDRV_UIO_GENERIC, + RTE_KDRV_NIC_UIO, }; Do you mean kdrv member will disappear in next DPDK release? Tetsuya > > > -- > David Marchand