Re: [dpdk-dev] [PATCH v2 5/5] net/hns3: fix queue enabling status not store after FLR

[oulijun <oulijun@huawei.com>]

在 2020/11/7 0:57, Ferruh Yigit 写道:
> On 11/6/2020 3:51 AM, Lijun Ou wrote:
>> From: Chengchang Tang <tangchengchang@huawei.com>
>>
>> The FLR will resets the queue enabling status. In the
>> current code, the queue enabling status is not restored
>> after the reset. Therefore, if upper layer users have
>> called queue start/stop function before the reset, the
>> behavior after the reset is not as expected.
>>
>> This patch fix it by add a queue enabling status restore
>> function to the reset handler.
>>
> 
> Can you please re-work above description, it looks like it can be improved.
> 
Thanks. I will try to re-work in next version.
> 
>> Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> ---
>>   drivers/net/hns3/hns3_ethdev.c    |  5 +++++
>>   drivers/net/hns3/hns3_ethdev_vf.c |  5 +++++
>>   drivers/net/hns3/hns3_rxtx.c      | 20 ++++++++++++++++++++
>>   drivers/net/hns3/hns3_rxtx.h      |  1 +
>>   4 files changed, 31 insertions(+)
>>
>> diff --git a/drivers/net/hns3/hns3_ethdev.c 
>> b/drivers/net/hns3/hns3_ethdev.c
>> index b27cf67..e177549 100644
>> --- a/drivers/net/hns3/hns3_ethdev.c
>> +++ b/drivers/net/hns3/hns3_ethdev.c
>> @@ -5567,6 +5567,11 @@ hns3_start_service(struct hns3_adapter *hns)
>>           /* Enable interrupt of all rx queues before enabling queues */
>>           hns3_dev_all_rx_queue_intr_enable(hw, true);
>>           /*
>> +         * Enable state of each rxq and txq will be recovered after
>> +         * reset, so we need restore them before enable all tqps;
>> +         */
> 
> Same with the comments (this + below one) please. Also instead of 
> "enable state" or "enabling status", does it make sense to just say 
> 'state'?
good advice.
> 
> .
>