From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18DEFA0527; Mon, 9 Nov 2020 15:28:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4B6D5B3A; Mon, 9 Nov 2020 15:28:11 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id C5EF45AB8 for ; Mon, 9 Nov 2020 15:28:10 +0100 (CET) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CVCyC4cHzzkhVX for ; Mon, 9 Nov 2020 22:27:47 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Mon, 9 Nov 2020 22:27:49 +0800 To: Ferruh Yigit CC: , References: <1604586194-29523-1-git-send-email-oulijun@huawei.com> <1604634716-43484-1-git-send-email-oulijun@huawei.com> <1604634716-43484-6-git-send-email-oulijun@huawei.com> <612a397c-47e8-257c-4019-fc101da89472@intel.com> From: oulijun Message-ID: <559dde92-7d46-cd60-3bfb-9739ae57f770@huawei.com> Date: Mon, 9 Nov 2020 22:27:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <612a397c-47e8-257c-4019-fc101da89472@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/hns3: fix queue enabling status not store after FLR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2020/11/7 0:57, Ferruh Yigit 写道: > On 11/6/2020 3:51 AM, Lijun Ou wrote: >> From: Chengchang Tang >> >> The FLR will resets the queue enabling status. In the >> current code, the queue enabling status is not restored >> after the reset. Therefore, if upper layer users have >> called queue start/stop function before the reset, the >> behavior after the reset is not as expected. >> >> This patch fix it by add a queue enabling status restore >> function to the reset handler. >> > > Can you please re-work above description, it looks like it can be improved. > Thanks. I will try to re-work in next version. > >> Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengchang Tang >> Signed-off-by: Lijun Ou >> --- >> drivers/net/hns3/hns3_ethdev.c | 5 +++++ >> drivers/net/hns3/hns3_ethdev_vf.c | 5 +++++ >> drivers/net/hns3/hns3_rxtx.c | 20 ++++++++++++++++++++ >> drivers/net/hns3/hns3_rxtx.h | 1 + >> 4 files changed, 31 insertions(+) >> >> diff --git a/drivers/net/hns3/hns3_ethdev.c >> b/drivers/net/hns3/hns3_ethdev.c >> index b27cf67..e177549 100644 >> --- a/drivers/net/hns3/hns3_ethdev.c >> +++ b/drivers/net/hns3/hns3_ethdev.c >> @@ -5567,6 +5567,11 @@ hns3_start_service(struct hns3_adapter *hns) >> /* Enable interrupt of all rx queues before enabling queues */ >> hns3_dev_all_rx_queue_intr_enable(hw, true); >> /* >> + * Enable state of each rxq and txq will be recovered after >> + * reset, so we need restore them before enable all tqps; >> + */ > > Same with the comments (this + below one) please. Also instead of > "enable state" or "enabling status", does it make sense to just say > 'state'? good advice. > > . >