From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B4BF9A00C4;
	Wed,  9 Nov 2022 11:37:36 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A279D40693;
	Wed,  9 Nov 2022 11:37:36 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id CDCBD400EF
 for <dev@dpdk.org>; Wed,  9 Nov 2022 11:37:35 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 5141566;
 Wed,  9 Nov 2022 13:37:35 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 5141566
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1667990255;
 bh=sn00WK+bWng72neeF2qlIK+8Sa8tz1nqAg2YobssXF0=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=oT1kCcLCR5PvRnqH7hheAJnh1O/lTADiBpvz9TrxjYpxw6BzmVg5mxzyyvGVCc57Y
 39ChbzEBzw8IT7iyp5RoYiTb8fWCrEBOsvvLcUS6vLN6JeAUnDxqaGL7sQr23EGG4/
 METmPLarSb98uxQ/1XGb2v/ippciczbOPlWMcFT8=
Message-ID: <559e0593-e553-eaa5-321c-41a0e46a4329@oktetlabs.ru>
Date: Wed, 9 Nov 2022 13:37:35 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH V2] net/bonding: fix bond3 and bond4 process mbuf fast free
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>,
 Huisong Li <lihuisong@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@amd.com, 3chas3@gmail.com, humin29@huawei.com, 
 liudongdong3@huawei.com, huangdaode@huawei.com
References: <20221108084038.25136-1-lihuisong@huawei.com>
 <20221109022237.49757-1-lihuisong@huawei.com>
 <20221108192417.35ab2959@hermes.local>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20221108192417.35ab2959@hermes.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 11/9/22 06:24, Stephen Hemminger wrote:
> On Wed, 9 Nov 2022 10:22:37 +0800
> Huisong Li <lihuisong@huawei.com> wrote:
> 
>> The RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload can't be used in bonding
>> mode Broadcast and mode 8023AD. Currently, bonding driver forcibly removes
>> from the dev->data->dev_conf.txmode.offloads and processes as success in
>> bond_ethdev_configure(). But this still cause that rte_eth_dev_configure()
>> fails to execute because of the failure of validating Tx offload in the
>> eth_dev_validate_offloads(). So this patch moves the modification of txmode
>> offlaods to the stage of adding slave device to report the correct txmode
>> offloads.
>>
>> Fixes: 18c41457cbae ("net/bonding: fix mbuf fast free usage")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> 
> Looks good thanks.
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Applied to dpdk-next-net/main, thanks.