From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 452C45A5D for ; Wed, 15 Jul 2015 12:16:14 +0200 (CEST) Received: by wibud3 with SMTP id ud3so76885065wib.1 for ; Wed, 15 Jul 2015 03:16:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=cmtcvlWlB5TYfYrS2u0q9a/cV4F7yKIjqf8Mbk/RWFY=; b=SUM3FlRtSMh6kWxunoWyfiINdjscoviE5vvBVauwrtpBIt2jQfGw+5lpL2ni6tv0os pTqJa1QvUVu0FFwp/yIBG+qPuK+AexV5QdVJv+eteO2sMnOuY7teN0SyqvbEU5fXwYYh zqIyRzBDtjkGzSjsddX6G6GtAjkHTSE/RCmmPAW6HZSCkPR5ZzeOWWmBLAMo0G9dFDtd onBIfIzGvkFfyiMii9zJ5CyMsLBVB7nlAYXrScmRQ0tPtcN0ErfiHb+Gb6kKO5qoDhxl amW98sOA5Zl7zJkeFeBTCZev+D11Y1Tjau43Yjt+j/XY/sI0wbx3LlrybxdNup55ng8u /WhA== X-Gm-Message-State: ALoCoQn6Z61cu7JQAY/PIx3f/XnPVJktynnR6D9QrVuDyD0xj0uHXgI+Wl+zvLWKUTZCcDRFSeJq X-Received: by 10.180.20.198 with SMTP id p6mr14795806wie.38.1436955374164; Wed, 15 Jul 2015 03:16:14 -0700 (PDT) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id jz4sm7167423wjb.16.2015.07.15.03.16.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2015 03:16:13 -0700 (PDT) Message-ID: <55A632E7.6000108@6wind.com> Date: Wed, 15 Jul 2015 12:16:07 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Bruce Richardson , dev@dpdk.org References: <1436448159-8394-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1436448159-8394-1-git-send-email-bruce.richardson@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mbuf: clarify comment on adding TX offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 10:16:14 -0000 On 07/09/2015 03:22 PM, Bruce Richardson wrote: > The comment for TX offload flags stated that those flags started at bit > 55 and then were added to the right of that, leaving 8 bits reserved for > generic mbuf (i.e. non-offload) use. This comment may not have been > clear as 5 of the 8 flags which were reserved have now been used for TX > offloads. > This patch: > * updates the description so that it now reflects reality that > only three flags are available for generic mbuf use > * reserved the final generic flag so that it can't be taken over for TX > offload in future > * clarifies the comment for TX flags to indicate that they should be > counting downwards not upwards. > > Signed-off-by: Bruce Richardson Acked-by: Olivier Matz