From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <olivier.matz@6wind.com> Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id AC6C55A7A for <dev@dpdk.org>; Thu, 16 Jul 2015 09:54:11 +0200 (CEST) Received: by widic2 with SMTP id ic2so8005645wid.0 for <dev@dpdk.org>; Thu, 16 Jul 2015 00:54:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=HC1cEF6DtL1rPC6KmTmHORao5QHapm3J2u2lxhPep5c=; b=Zb5gaFaCRCfzHgeweQ/vL0HbTB8t8VeACCs5KbSVYceLRBrBowpMT5liX24p4829C8 yMF0MYByVpEFRR8iqtT6VD3X6Ok9dFKRraGoR4/TU4D8OzoeGxxlCtcMXf4dfbwQIJ7j WT0TVzPxOxB7oaE3x2sJYNybIlEZ08w7Hy86a38ntoK94a7kV6k2Yh/QnOBCgybteP1h 5M4rWKSXZUtUYtIvpTcBH5wR9+NYsIVJ+ZGJnaWDdJFwUeYgbC1R0X4mvl++43HIvRo+ rVlQMNzoRzNv0IIpVc9zDzQsY1GKhVwD4Ho6B/WDL0L8ZAGo/1GJ8N24aCPRc+2g+rAZ hMJg== X-Gm-Message-State: ALoCoQkU7iulI9kCz1Ibyow/fX1JNpEC6IBi6nG9vPlJ5jZLo4zrhNIdYQ10VHCij/NiJ7ECzT37 X-Received: by 10.194.122.132 with SMTP id ls4mr15338582wjb.130.1437033251495; Thu, 16 Jul 2015 00:54:11 -0700 (PDT) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id ev8sm11622769wjb.8.2015.07.16.00.54.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 00:54:10 -0700 (PDT) Message-ID: <55A7631C.3020408@6wind.com> Date: Thu, 16 Jul 2015 09:54:04 +0200 From: Olivier MATZ <olivier.matz@6wind.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Maryam Tahhan <maryam.tahhan@intel.com>, dev@dpdk.org References: <1436965894-130019-1-git-send-email-maryam.tahhan@intel.com> In-Reply-To: <1436965894-130019-1-git-send-email-maryam.tahhan@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 0/9] Expose IXGBE extended stats to DPDK apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 16 Jul 2015 07:54:12 -0000 Hi Maryam, On 07/15/2015 03:11 PM, Maryam Tahhan wrote: > This patch set implements xstats_get() and xstats_reset() in dev_ops for > ixgbe to expose detailed error statistics to DPDK applications. The > dump_cfg application was extended to demonstrate the usage of > retrieving statistics for DPDK interfaces and renamed to proc_info > in order reflect this new functionality. This patch set also removes non > generic statistics from the statistics strings at the ethdev level and > marks the relevant registers as depricated in struct rte_eth_stats. > > v2: > - Fixed patch dependencies. > - Broke down patches into smaller logical changes. > > v3: > - Removes non-generic stats fields in rte_stats_strings and deprecates > the fields related to them in struct rte_eth_stats. > - Modifies rte_eth_xstats_get() to return generic stats and extended > stats. > > v4: > - Replace count use in the loop in ixgbe_dev_xstats_get() function > definition with i. > - Breakdown "ixgbe: add NIC specific stats removed from ethdev" into > two patches, one that adds the stats and another that extends > ierrors to include more error stats. > - Remove second call to ixgbe_dev_xstats_get() from > rte_eth_xstats_get(). > > v5: > - Added documentation for proc_info. > - Fixed proc_info copyright year. > - Display queue stats for all devices in proc_info. > > v6: > - Modified the driver implementation of ixgbe_dev_xstats_get() so that > it doesn't worry about the generic stats written by the generic layer. > > Maryam Tahhan (9): > ixgbe: move stats register reads to a new function > ixgbe: add functions to get and reset xstats > ethdev: expose extended error stats > ethdev: remove HW specific stats in stats structs > ixgbe: add NIC specific stats removed from ethdev > ixgbe: return more errors in ierrors > app: remove dump_cfg > app: add a new app proc_info > doc: Add documentation for proc_info > > MAINTAINERS | 4 + > app/Makefile | 2 +- > app/dump_cfg/Makefile | 45 ----- > app/dump_cfg/main.c | 92 --------- > app/proc_info/Makefile | 45 +++++ > app/proc_info/main.c | 354 +++++++++++++++++++++++++++++++++ > doc/guides/rel_notes/abi.rst | 12 ++ > doc/guides/sample_app_ug/index.rst | 1 + > doc/guides/sample_app_ug/proc_info.rst | 71 +++++++ > drivers/net/ixgbe/ixgbe_ethdev.c | 193 ++++++++++++++---- > lib/librte_ether/rte_ethdev.c | 40 ++-- > lib/librte_ether/rte_ethdev.h | 30 ++- > mk/rte.sdktest.mk | 4 +- > 13 files changed, 685 insertions(+), 208 deletions(-) > delete mode 100644 app/dump_cfg/Makefile > delete mode 100644 app/dump_cfg/main.c > create mode 100644 app/proc_info/Makefile > create mode 100644 app/proc_info/main.c > create mode 100644 doc/guides/sample_app_ug/proc_info.rst > mode change 100644 => 100755 lib/librte_ether/rte_ethdev.c Acked-by: Olivier Matz <olivier.matz@6wind.com>