From: Alexander Duyck <alexander.duyck@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Jing Chen <jing.d.chen@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fm10k: add missing newline to debug log
Date: Thu, 16 Jul 2015 11:24:49 -0700 [thread overview]
Message-ID: <55A7F6F1.4020709@gmail.com> (raw)
In-Reply-To: <1437067585-579-1-git-send-email-stephen@networkplumber.org>
On 07/16/2015 10:26 AM, Stephen Hemminger wrote:
> If FM10K_DEBUG_DRIVER is enabled, then the log messages about
> function entry are missing newline causing extremely long lines.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
> index 04f8fe9..33d9120 100644
> --- a/drivers/net/fm10k/base/fm10k_osdep.h
> +++ b/drivers/net/fm10k/base/fm10k_osdep.h
> @@ -46,7 +46,7 @@ POSSIBILITY OF SUCH DAMAGE.
>
> #define STATIC static
> #define DEBUGFUNC(F) DEBUGOUT(F);
> -#define DEBUGOUT(S, args...) PMD_DRV_LOG_RAW(DEBUG, S, ##args)
> +#define DEBUGOUT(S, args...) PMD_DRV_LOG_RAW(DEBUG, S "\n", ##args)
> #define DEBUGOUT1(S, args...) DEBUGOUT(S, ##args)
> #define DEBUGOUT2(S, args...) DEBUGOUT(S, ##args)
> #define DEBUGOUT3(S, args...) DEBUGOUT(S, ##args)
I think this ends up adding a redundant "\n" to several other DEBUGOUT
statements then. Maybe you should update it so that DEBUGFUNC adds the
"\n" instead of DEBUGOUT.
- Alex
prev parent reply other threads:[~2015-07-16 18:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 17:26 Stephen Hemminger
2015-07-16 18:24 ` Alexander Duyck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A7F6F1.4020709@gmail.com \
--to=alexander.duyck@gmail.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).