From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f178.google.com (mail-ig0-f178.google.com [209.85.213.178]) by dpdk.org (Postfix) with ESMTP id 953BE5A3E for ; Thu, 16 Jul 2015 20:24:51 +0200 (CEST) Received: by iggf3 with SMTP id f3so20161869igg.1 for ; Thu, 16 Jul 2015 11:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=IHyymcchwH6gA3TWKDXJw7uylvcqCDuz2pcL5lu2ujo=; b=quwQs+jvWRBS4pcAfoxpXyvYsDmLriEiGOKerzi2Lrq2ebL8vqq1cZuO539Bw9xaW2 upkIvMO1o9mz9fxqrXcescayUhlLkw/DqQfcnQymoMe2q0EliK7MVMLw+2+4wNcXXqcO 8z+zp0dnUfifZVpNqh7jtaid6psxf6SQAX+iAWnBWKCD2DfJHAul5veK/VIWcl5ijMRs t/ClqRLPA9W8RcdqPsD5tuB6rK+ZXEnWRz3ZYIQrvgqJowZfuAnttp0jOrpzkOS9lqHT nM539E52RKQ+YUU/SaDywLrFkIWWwA0Ace3iWx/66l70CkxT3lWt3qjmnmXM3KpOyedU SSMA== X-Received: by 10.107.135.148 with SMTP id r20mr12282732ioi.153.1437071091075; Thu, 16 Jul 2015 11:24:51 -0700 (PDT) Received: from [192.168.1.188] (50-43-10-6.bvtn.or.frontiernet.net. [50.43.10.6]) by smtp.googlemail.com with ESMTPSA id t66sm1702022ioi.32.2015.07.16.11.24.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 11:24:50 -0700 (PDT) Message-ID: <55A7F6F1.4020709@gmail.com> Date: Thu, 16 Jul 2015 11:24:49 -0700 From: Alexander Duyck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Hemminger , Jing Chen References: <1437067585-579-1-git-send-email-stephen@networkplumber.org> In-Reply-To: <1437067585-579-1-git-send-email-stephen@networkplumber.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] fm10k: add missing newline to debug log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 18:24:52 -0000 On 07/16/2015 10:26 AM, Stephen Hemminger wrote: > If FM10K_DEBUG_DRIVER is enabled, then the log messages about > function entry are missing newline causing extremely long lines. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/fm10k/base/fm10k_osdep.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h > index 04f8fe9..33d9120 100644 > --- a/drivers/net/fm10k/base/fm10k_osdep.h > +++ b/drivers/net/fm10k/base/fm10k_osdep.h > @@ -46,7 +46,7 @@ POSSIBILITY OF SUCH DAMAGE. > > #define STATIC static > #define DEBUGFUNC(F) DEBUGOUT(F); > -#define DEBUGOUT(S, args...) PMD_DRV_LOG_RAW(DEBUG, S, ##args) > +#define DEBUGOUT(S, args...) PMD_DRV_LOG_RAW(DEBUG, S "\n", ##args) > #define DEBUGOUT1(S, args...) DEBUGOUT(S, ##args) > #define DEBUGOUT2(S, args...) DEBUGOUT(S, ##args) > #define DEBUGOUT3(S, args...) DEBUGOUT(S, ##args) I think this ends up adding a redundant "\n" to several other DEBUGOUT statements then. Maybe you should update it so that DEBUGFUNC adds the "\n" instead of DEBUGOUT. - Alex