* [dpdk-dev] [PATCH] fm10k: add missing newline to debug log
@ 2015-07-16 17:26 Stephen Hemminger
2015-07-16 18:24 ` Alexander Duyck
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2015-07-16 17:26 UTC (permalink / raw)
To: Jing Chen; +Cc: dev
If FM10K_DEBUG_DRIVER is enabled, then the log messages about
function entry are missing newline causing extremely long lines.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
index 04f8fe9..33d9120 100644
--- a/drivers/net/fm10k/base/fm10k_osdep.h
+++ b/drivers/net/fm10k/base/fm10k_osdep.h
@@ -46,7 +46,7 @@ POSSIBILITY OF SUCH DAMAGE.
#define STATIC static
#define DEBUGFUNC(F) DEBUGOUT(F);
-#define DEBUGOUT(S, args...) PMD_DRV_LOG_RAW(DEBUG, S, ##args)
+#define DEBUGOUT(S, args...) PMD_DRV_LOG_RAW(DEBUG, S "\n", ##args)
#define DEBUGOUT1(S, args...) DEBUGOUT(S, ##args)
#define DEBUGOUT2(S, args...) DEBUGOUT(S, ##args)
#define DEBUGOUT3(S, args...) DEBUGOUT(S, ##args)
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: add missing newline to debug log
2015-07-16 17:26 [dpdk-dev] [PATCH] fm10k: add missing newline to debug log Stephen Hemminger
@ 2015-07-16 18:24 ` Alexander Duyck
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Duyck @ 2015-07-16 18:24 UTC (permalink / raw)
To: Stephen Hemminger, Jing Chen; +Cc: dev
On 07/16/2015 10:26 AM, Stephen Hemminger wrote:
> If FM10K_DEBUG_DRIVER is enabled, then the log messages about
> function entry are missing newline causing extremely long lines.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/fm10k/base/fm10k_osdep.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fm10k/base/fm10k_osdep.h b/drivers/net/fm10k/base/fm10k_osdep.h
> index 04f8fe9..33d9120 100644
> --- a/drivers/net/fm10k/base/fm10k_osdep.h
> +++ b/drivers/net/fm10k/base/fm10k_osdep.h
> @@ -46,7 +46,7 @@ POSSIBILITY OF SUCH DAMAGE.
>
> #define STATIC static
> #define DEBUGFUNC(F) DEBUGOUT(F);
> -#define DEBUGOUT(S, args...) PMD_DRV_LOG_RAW(DEBUG, S, ##args)
> +#define DEBUGOUT(S, args...) PMD_DRV_LOG_RAW(DEBUG, S "\n", ##args)
> #define DEBUGOUT1(S, args...) DEBUGOUT(S, ##args)
> #define DEBUGOUT2(S, args...) DEBUGOUT(S, ##args)
> #define DEBUGOUT3(S, args...) DEBUGOUT(S, ##args)
I think this ends up adding a redundant "\n" to several other DEBUGOUT
statements then. Maybe you should update it so that DEBUGFUNC adds the
"\n" instead of DEBUGOUT.
- Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-16 18:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-16 17:26 [dpdk-dev] [PATCH] fm10k: add missing newline to debug log Stephen Hemminger
2015-07-16 18:24 ` Alexander Duyck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).