From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: "Rauta, Alin" <alin.rauta@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Varlese, Marco" <marco.varlese@intel.com>
Subject: Re: [dpdk-dev] [PATCH] DPDK fails to build into one single library ("CONFIG_RTE_BUILD_COMBINE_LIBS=y").
Date: Tue, 21 Jul 2015 10:53:39 +0100 [thread overview]
Message-ID: <55AE16A3.6040701@intel.com> (raw)
In-Reply-To: <313CE12EB78416478E6F6FC8F09CCF8C354185@IRSMSX101.ger.corp.intel.com>
On 21/07/2015 10:49, Rauta, Alin wrote:
> The reason why I took into account as a solution the commenting of that line is that LIBRTE_EAL already has rte_malloc integrated.
> So, I'm not sure why the line is needed ...
> /Alin
That line is needed so when we create shared libs it creates a dummy lib
so we don't brake apps that expect a librte_malloc.so.
I'm working on a fix, will post it soon.
Sergio
>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, July 20, 2015 7:15 PM
> To: Rauta, Alin
> Cc: dev@dpdk.org; Varlese, Marco
> Subject: Re: [dpdk-dev] [PATCH] DPDK fails to build into one single library ("CONFIG_RTE_BUILD_COMBINE_LIBS=y").
>
> 2015-07-20 18:04, Rauta, Alin:
>> --- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -33,7 +33,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
>>
>> DIRS-y += librte_compat
>> DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_eal
>> -DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_malloc
> I feel it's not the right fix :)
>
> From now, I'll test combine lib build.
> Thanks for reporting
prev parent reply other threads:[~2015-07-21 9:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1437389608-18697-1-git-send-email-alin.rauta@intel.com>
2015-07-20 18:03 ` Rauta, Alin
2015-07-21 10:18 ` [dpdk-dev] [PATCH] malloc: fix combined lib build Sergio Gonzalez Monroy
2015-07-21 10:18 ` Sergio Gonzalez Monroy
2015-07-21 10:20 ` Gonzalez Monroy, Sergio
2015-07-21 10:33 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
2015-07-22 8:26 ` Thomas Monjalon
[not found] ` <1437389608-18697-2-git-send-email-alin.rauta@intel.com>
2015-07-20 18:04 ` [dpdk-dev] [PATCH] DPDK fails to build into one single library ("CONFIG_RTE_BUILD_COMBINE_LIBS=y") Rauta, Alin
2015-07-20 18:14 ` Thomas Monjalon
2015-07-21 9:49 ` Rauta, Alin
2015-07-21 9:53 ` Gonzalez Monroy, Sergio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE16A3.6040701@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=alin.rauta@intel.com \
--cc=dev@dpdk.org \
--cc=marco.varlese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).