From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 71BF25A0C for ; Tue, 21 Jul 2015 11:53:42 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 21 Jul 2015 02:53:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,515,1432623600"; d="scan'208";a="766557511" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.14]) ([10.237.221.14]) by fmsmga002.fm.intel.com with ESMTP; 21 Jul 2015 02:53:40 -0700 Message-ID: <55AE16A3.6040701@intel.com> Date: Tue, 21 Jul 2015 10:53:39 +0100 From: "Gonzalez Monroy, Sergio" User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Rauta, Alin" References: <1437389608-18697-1-git-send-email-alin.rauta@intel.com> <1437389608-18697-2-git-send-email-alin.rauta@intel.com> <313CE12EB78416478E6F6FC8F09CCF8C353CB9@IRSMSX101.ger.corp.intel.com> <1754975.lJ4YckftyJ@xps13> <313CE12EB78416478E6F6FC8F09CCF8C354185@IRSMSX101.ger.corp.intel.com> In-Reply-To: <313CE12EB78416478E6F6FC8F09CCF8C354185@IRSMSX101.ger.corp.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "Varlese, Marco" Subject: Re: [dpdk-dev] [PATCH] DPDK fails to build into one single library ("CONFIG_RTE_BUILD_COMBINE_LIBS=y"). X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2015 09:53:42 -0000 On 21/07/2015 10:49, Rauta, Alin wrote: > The reason why I took into account as a solution the commenting of that line is that LIBRTE_EAL already has rte_malloc integrated. > So, I'm not sure why the line is needed ... > /Alin That line is needed so when we create shared libs it creates a dummy lib so we don't brake apps that expect a librte_malloc.so. I'm working on a fix, will post it soon. Sergio > > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, July 20, 2015 7:15 PM > To: Rauta, Alin > Cc: dev@dpdk.org; Varlese, Marco > Subject: Re: [dpdk-dev] [PATCH] DPDK fails to build into one single library ("CONFIG_RTE_BUILD_COMBINE_LIBS=y"). > > 2015-07-20 18:04, Rauta, Alin: >> --- a/lib/Makefile >> +++ b/lib/Makefile >> @@ -33,7 +33,6 @@ include $(RTE_SDK)/mk/rte.vars.mk >> >> DIRS-y += librte_compat >> DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_eal >> -DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_malloc > I feel it's not the right fix :) > > From now, I'll test combine lib build. > Thanks for reporting