From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5A02C5A5E for ; Tue, 21 Jul 2015 12:21:01 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 21 Jul 2015 03:21:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,515,1432623600"; d="scan'208";a="732655355" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.14]) ([10.237.221.14]) by orsmga001.jf.intel.com with ESMTP; 21 Jul 2015 03:20:59 -0700 Message-ID: <55AE1D0B.4010001@intel.com> Date: Tue, 21 Jul 2015 11:20:59 +0100 From: "Gonzalez Monroy, Sergio" User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: dev@dpdk.org References: <313CE12EB78416478E6F6FC8F09CCF8C353CAD@IRSMSX101.ger.corp.intel.com> <1437473890-17279-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1437473890-17279-2-git-send-email-sergio.gonzalez.monroy@intel.com> In-Reply-To: <1437473890-17279-2-git-send-email-sergio.gonzalez.monroy@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] malloc: fix combined lib build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2015 10:21:01 -0000 On 21/07/2015 11:18, Sergio Gonzalez Monroy wrote: > Malloc was moved to the EAL and dummy malloc library was left > to not brake apps that had a librte_malloc.so dependency. > Note that the dummy library will be removed in the next release. > > When building a combined library, all objects are copied to the same > directory before creating the library itself. > > There a couple of issues: > - CONFIG_RTE_LIBRTE_MALLOC is not a valid option anymore resulting > in wrong syntax and a compilation failure. Fix it by replacing it > with CONFIG_RTE_LIBRTE_EAL. > - As we kept a dummy library, there are now two objects with the > same name. This means that the proper rte_malloc.o object in eal gets > overwritten by an empty rte_malloc.o object from the dummy malloc lib. > Fix it by changing the name of rte_malloc.o object in the dummy > library. > > Fixes: 2f9d47013e4dbb738 ("mem: move librte_malloc to eal/common") > > Reported-by: Alin Rauta > Signed-off-by: Sergio Gonzalez Monroy > --- > I sent the same patch twice by accident, please ignore the second patch. Sergio