DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] hash: fix crash when adding already inserted keys
@ 2015-07-28 14:54 Xavier Simonart
  2015-07-28 15:07 ` Gonzalez Monroy, Sergio
  0 siblings, 1 reply; 3+ messages in thread
From: Xavier Simonart @ 2015-07-28 14:54 UTC (permalink / raw)
  To: dev, xavier.simonart

When adding with cuckoo hash a key which was already inserted
a new slot is dequeued and then enqueued back, but the enqueue
operation was not done properly.

Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
---
 lib/librte_hash/rte_cuckoo_hash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c
index 5cf4af6..4da859a 100644
--- a/lib/librte_hash/rte_cuckoo_hash.c
+++ b/lib/librte_hash/rte_cuckoo_hash.c
@@ -509,7 +509,7 @@ __rte_hash_add_key_with_hash(const struct rte_hash *h, const void *key,
 			k = (struct rte_hash_key *) ((char *)keys +
 					prim_bkt->key_idx[i] * h->key_entry_size);
 			if (h->rte_hash_cmp_eq(key, k->key, h->key_len) == 0) {
-				rte_ring_sp_enqueue(h->free_slots, &slot_id);
+				rte_ring_sp_enqueue(h->free_slots, slot_id);
 				/* Update data */
 				k->pdata = data;
 				/*
@@ -528,7 +528,7 @@ __rte_hash_add_key_with_hash(const struct rte_hash *h, const void *key,
 			k = (struct rte_hash_key *) ((char *)keys +
 					sec_bkt->key_idx[i] * h->key_entry_size);
 			if (h->rte_hash_cmp_eq(key, k->key, h->key_len) == 0) {
-				rte_ring_sp_enqueue(h->free_slots, &slot_id);
+				rte_ring_sp_enqueue(h->free_slots, slot_id);
 				/* Update data */
 				k->pdata = data;
 				/*
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-28 17:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-28 14:54 [dpdk-dev] [PATCH] hash: fix crash when adding already inserted keys Xavier Simonart
2015-07-28 15:07 ` Gonzalez Monroy, Sergio
2015-07-28 17:35   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).