From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2CC80C376 for ; Wed, 29 Jul 2015 17:05:56 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 29 Jul 2015 08:05:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,571,1432623600"; d="scan'208";a="615256784" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.220.43]) ([10.237.220.43]) by orsmga003.jf.intel.com with ESMTP; 29 Jul 2015 08:05:54 -0700 Message-ID: <55B8EBD1.5090104@intel.com> Date: Wed, 29 Jul 2015 16:05:53 +0100 From: "Gonzalez Monroy, Sergio" User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Zhang, Helin" References: <1438123707-26509-1-git-send-email-helin.zhang@intel.com> <4457109.BKbKVosbHQ@xps13> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal: fix build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 15:05:56 -0000 On 29/07/2015 16:00, Zhang, Helin wrote: > Hi Thomas > > It was just an implicit declaration of function, when set CONFIG_RTE_PCI_CONFIG=y, as follows. Nobody else cares about it. > > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c: In function �rte_eal_pci_probe_one_driver’: > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c:188:4: error: implicit declaration of function �pci_config_space_set’ [-Werror=implicit-function-declaration] > pci_config_space_set(dev); > ^ > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c:188:4: error: nested extern declaration of �pci_config_space_set’ [-Werror=nested-externs] > cc1: all warnings being treated as errors > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/linuxapp/eal/eal_pci.c:561:1: error: �pci_config_space_set’ defined but not used [-Werror=unused-function] > pci_config_space_set(struct rte_pci_device *dev) > ^ > cc1: all warnings being treated as errors > > Regards, > Helin > >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] >> Sent: Wednesday, July 29, 2015 1:20 AM >> To: Zhang, Helin >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] eal: fix build >> >> 2015-07-29 06:48, Helin Zhang: >>> It fixes the build error of implicit declaration of function. >> What is the error? >> Please show the build log and describe the case when it happens (compiler, >> version). Fixes: 4d4ebca4 ("pci: merge probing and closing functions for linux and bsd") The function rte_eal_pci_probe_one_driver, which calls pci_config_space_set, was moved to eal_common_pci.c, but pci_config_space_set was left in eal_pci.c with static specifier. Sergio