From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 29CC1C4DE for ; Thu, 30 Jul 2015 10:12:40 +0200 (CEST) Received: by wibud3 with SMTP id ud3so10703293wib.1 for ; Thu, 30 Jul 2015 01:12:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=n3tAz9z4c22zPweaa399kbYmOvPX0+Bbw2ORjLexXAY=; b=l2UDJXtnRenPJSFuPyCHWjhPPqAqueTWoja8bJ9QJSleZkOJ+hi6q6HUfMWM4nlqd9 OED6qZOTKqzpmTIm+FbFO1ADhop+dy0gupJLa2I4M+gYbwlKniDbcigOOsggrMnYzQlJ 0A4ZZHJTJZ4EOOq3j7Gu3Dw9zFdp/r3HIyRrjX2BIaC9bj0mTCYiBy0+u5SlVnJdWgY+ Kx86Sklb1srb6/ToB+2QDXaybPQ144HQ/TzfUZ6ljYRarOzdrxvooOjbgjMy8FuVSBBA 2SmNO2ZjZOQBME70q6c0ibs85TISdo0sQI72EvOIf3bJBlCUsjYaozHIOwFfXA7c//f/ FHzQ== X-Gm-Message-State: ALoCoQmQbYloETlGjhI6hqfXSwJ7PqyChZwdbI+z9lPi76jMmnzp8bQd7CUmhjWezkTiHolboBxE X-Received: by 10.194.171.200 with SMTP id aw8mr66694127wjc.62.1438243960003; Thu, 30 Jul 2015 01:12:40 -0700 (PDT) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id hd6sm28496329wib.19.2015.07.30.01.12.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jul 2015 01:12:39 -0700 (PDT) Message-ID: <55B9DC6F.7040506@6wind.com> Date: Thu, 30 Jul 2015 10:12:31 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Thomas Monjalon , rkerur@gmail.com References: <1437852868-6031-1-git-send-email-rkerur@gmail.com> <1437958594-29468-1-git-send-email-thomas.monjalon@6wind.com> <3055506.vZLM2IGfDr@xps13> In-Reply-To: <3055506.vZLM2IGfDr@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v10 0/3] deduplicate EAL common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2015 08:12:40 -0000 Hi Thomas & Ravi, On 07/27/2015 02:59 AM, Thomas Monjalon wrote: > 2015-07-27 02:56, Thomas Monjalon: >> v9 was a subset of previous deduplications by Ravi Kerur. >> This v10 address the comments I've done on v9. >> >> Ravi Kerur (3): >> eal: deduplicate lcore initialization >> eal: deduplicate timer functions >> eal: deduplicate memory initialization > > Applied shortly to integrate this old pending cleanup in RC2. > When I try to compile the dpdk for x86_x32-native-linuxapp-gcc , I get the following compilation error: CC eal_common_timer.o In file included from /usr/include/sys/sysctl.h:63:0, from /home/matz/dpdk-pkg-cron/dpdk.org/lib/librte_eal/common/eal_common_timer.c:39: /usr/include/bits/sysctl.h:19:3: error: #error "sysctl system call is unsupported in x32 kernel" # error "sysctl system call is unsupported in x32 kernel" ^ Removing the "#include " line fixes the issue without impacting the compilation. I think this include is not needed and could be removed. I can provide a patch if it's ok for you. Regards, Olivier