From: Zoltan Kiss <zoltan.kiss@linaro.org>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Liang, Cunming" <cunming.liang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] ixgbe: remove vector pmd burst size restriction
Date: Fri, 31 Jul 2015 15:49:33 +0100 [thread overview]
Message-ID: <55BB8AFD.7010407@linaro.org> (raw)
In-Reply-To: <55BB62A3.2040906@linaro.org>
On 31/07/15 12:57, Zoltan Kiss wrote:
>>
>> Another thing, that I just thought about:
>> Right now we invoke ixgbe_rxq_rearm() only at the start of
>> _recv_raw_pkts_vec().
>> Before it was ok, as _recv_raw_pkts_vec() would never try to read more
>> then 32 RXDs.
>> But what would happen if nb_pkts > rxq->nb_desc and rxq->rxrearm_nb == 0?
> Yes, that call would deplete the RX ring, the card wouldn't be able to
> receive more, so the receive function wouldn't be called again to rearm
> the ring.
>
Actually not, the problem is that the recv function would probably
overran the the descriptor ring. But anyway, we should limit nb_pkts indeed.
next prev parent reply other threads:[~2015-07-31 14:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 8:17 Cunming Liang
2015-07-31 9:21 ` Ananyev, Konstantin
2015-07-31 10:03 ` Zoltan Kiss
2015-07-31 10:21 ` Ananyev, Konstantin
2015-07-31 11:57 ` Zoltan Kiss
2015-07-31 14:49 ` Zoltan Kiss [this message]
2015-08-03 7:41 ` Liang, Cunming
2015-08-03 9:59 ` Liang, Cunming
2015-08-03 2:40 ` Liang, Cunming
2015-08-04 7:32 ` [dpdk-dev] [PATCH v2] " Cunming Liang
2015-08-04 9:02 ` Zoltan Kiss
2015-08-04 11:15 ` Liang, Cunming
2015-08-04 11:47 ` [dpdk-dev] [PATCH v3] " Cunming Liang
2015-08-04 16:26 ` Zoltan Kiss
2015-08-05 6:28 ` Liang, Cunming
2015-08-05 15:59 ` Zoltan Kiss
2015-08-05 9:31 ` Ananyev, Konstantin
2015-09-09 13:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BB8AFD.7010407@linaro.org \
--to=zoltan.kiss@linaro.org \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).