From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp03.in.ibm.com (e28smtp03.in.ibm.com [122.248.162.3]) by dpdk.org (Postfix) with ESMTP id 2FF17C3F0 for ; Mon, 3 Aug 2015 04:40:03 +0200 (CEST) Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Aug 2015 08:10:01 +0530 Received: from d28dlp03.in.ibm.com (9.184.220.128) by e28smtp03.in.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 3 Aug 2015 08:09:58 +0530 X-Helo: d28dlp03.in.ibm.com X-MailFrom: chaozhu@linux.vnet.ibm.com X-RcptTo: dev@dpdk.org Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 377C8125801B for ; Mon, 3 Aug 2015 08:13:05 +0530 (IST) Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay01.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t732dv0065339608 for ; Mon, 3 Aug 2015 08:09:57 +0530 Received: from d28av01.in.ibm.com (localhost [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t732dvHW017494 for ; Mon, 3 Aug 2015 08:09:57 +0530 Received: from [9.186.50.80] ([9.186.50.80]) by d28av01.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t732dtIq017428; Mon, 3 Aug 2015 08:09:55 +0530 Message-ID: <55BED47A.8030001@linux.vnet.ibm.com> Date: Mon, 03 Aug 2015 10:39:54 +0800 From: Chao Zhu User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: nhorman@tuxdriver.com, thomas.monjalon@6wind.com, "Mcnamara, John" References: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com> <20150713104218.GB9631@hmsreliant.think-freely.org> <20150713135955.GC9631@hmsreliant.think-freely.org> <20150731103430.GA16823@hmsreliant.think-freely.org> In-Reply-To: <20150731103430.GA16823@hmsreliant.think-freely.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15080302-0009-0000-0000-000006DCDEE3 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2015 02:40:03 -0000 Really sorry for the delay. Originally, I thought the email was to asking the ABI checking tools on Power which I'm not so familiar with. So this took me some time to find solution. For Power little endian, the build is OK. I'll give feedback when I tried Big endian compilation. On 2015/7/31 18:34, Neil Horman wrote: > On Fri, Jul 31, 2015 at 09:03:45AM +0000, Mcnamara, John wrote: >>> -----Original Message----- >>> From: Neil Horman [mailto:nhorman@tuxdriver.com] >>> Sent: Monday, July 13, 2015 3:00 PM >>> To: Mcnamara, John >>> Cc: dev@dpdk.org; vladz@cloudius-systems.com >>> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code >>> >>> On Mon, Jul 13, 2015 at 10:47:03AM +0000, Mcnamara, John wrote: >>>>> -----Original Message----- >>>>> From: Neil Horman [mailto:nhorman@tuxdriver.com] >>>>> Sent: Monday, July 13, 2015 11:42 AM >>>>> To: Mcnamara, John >>>>> Cc: dev@dpdk.org; vladz@cloudius-systems.com >>>>> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code >>>>> >>>>> On Mon, Jul 13, 2015 at 11:26:25AM +0100, John McNamara wrote: >>>>>> Fix for ABI breakage introduced in LRO addition. Moves lro >>>>>> bitfield to the end of the struct/member. >>>>>> >>>>>> Fixes: 8eecb3295aed (ixgbe: add LRO support) >>>>>> >>>>>> Signed-off-by: John McNamara >>>>>> --- >>>>>> lib/librte_ether/rte_ethdev.h | 4 ++-- >>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/lib/librte_ether/rte_ethdev.h >>>>>> b/lib/librte_ether/rte_ethdev.h index 79bde89..1c3ace1 100644 >>>>>> --- a/lib/librte_ether/rte_ethdev.h >>>>>> +++ b/lib/librte_ether/rte_ethdev.h >>>>>> @@ -1578,9 +1578,9 @@ struct rte_eth_dev_data { >>>>>> uint8_t port_id; /**< Device [external] port >>> identifier. >>>>> */ >>>>>> uint8_t promiscuous : 1, /**< RX promiscuous mode ON(1) / >>> OFF(0). >>>>> */ >>>>>> scattered_rx : 1, /**< RX of scattered packets is ON(1) >>> / >>>>> OFF(0) */ >>>>>> - lro : 1, /**< RX LRO is ON(1) / OFF(0) */ >>>>>> all_multicast : 1, /**< RX all multicast mode ON(1) / >>> OFF(0). >>>>> */ >>>>>> - dev_started : 1; /**< Device state: STARTED(1) / >>> STOPPED(0). >>>>> */ >>>>>> + dev_started : 1, /**< Device state: STARTED(1) / >>> STOPPED(0). >>>>> */ >>>>>> + lro : 1; /**< RX LRO is ON(1) / OFF(0) */ >>>>>> }; >>>>>> >>>>>> /** >>>>>> -- >>>>>> 1.8.1.4 >>>>>> >>>>>> >>>>> I presume the ABI checker stopped complaining about this with the >>>>> patch, yes? >>>> Hi Neil, >>>> >>>> Yes, I replied about that in the previous thread. >>>> >>> Thank you, I'll ack as soon as Chao confirms its not a problem on ppc Neil >> Hi Chao, >> >> Any reply on this. >> >> Neil, if there is no reply to this from the PPC maintainer do you have any objection to this going in as is. >> >> It at least fixes the LRO ABI breakage on the platforms we can test on. >> >> John >> > Well, I suppose at this point the only thing its hurting is ppc, so no, no > objections. But its pretty disheartening for an arch maintainer to dissappear > so soon after adding arch support. > > Neil >