From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <chaozhu@linux.vnet.ibm.com>
Received: from e23smtp09.au.ibm.com (e23smtp09.au.ibm.com [202.81.31.142])
by dpdk.org (Postfix) with ESMTP id 1FCC7C3C2
for <dev@dpdk.org>; Mon, 3 Aug 2015 05:46:41 +0200 (CEST)
Received: from /spool/local
by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
Violators will be prosecuted
for <dev@dpdk.org> from <chaozhu@linux.vnet.ibm.com>;
Mon, 3 Aug 2015 13:46:40 +1000
Received: from d23dlp02.au.ibm.com (202.81.31.213)
by e23smtp09.au.ibm.com (202.81.31.206) with IBM ESMTP SMTP Gateway:
Authorized Use Only! Violators will be prosecuted;
Mon, 3 Aug 2015 13:46:38 +1000
X-Helo: d23dlp02.au.ibm.com
X-MailFrom: chaozhu@linux.vnet.ibm.com
X-RcptTo: dev@dpdk.org
Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33])
by d23dlp02.au.ibm.com (Postfix) with ESMTP id A4E542BB0057
for <dev@dpdk.org>; Mon, 3 Aug 2015 13:46:36 +1000 (EST)
Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])
by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
t733kNYU55378108 for <dev@dpdk.org>; Mon, 3 Aug 2015 13:46:32 +1000
Received: from d23av02.au.ibm.com (localhost [127.0.0.1])
by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
t733k41d004859 for <dev@dpdk.org>; Mon, 3 Aug 2015 13:46:04 +1000
Received: from [9.186.50.80] ([9.186.50.80])
by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id
t733k2Ao004512; Mon, 3 Aug 2015 13:46:02 +1000
Message-ID: <55BEE3EA.90006@linux.vnet.ibm.com>
Date: Mon, 03 Aug 2015 11:45:46 +0800
From: Chao Zhu <chaozhu@linux.vnet.ibm.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: nhorman@tuxdriver.com, thomas.monjalon@6wind.com,
"Mcnamara, John" <john.mcnamara@intel.com>
References: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com>
<20150713104218.GB9631@hmsreliant.think-freely.org>
<B27915DBBA3421428155699D51E4CFE2F6B3FA@IRSMSX103.ger.corp.intel.com>
<20150713135955.GC9631@hmsreliant.think-freely.org>
<B27915DBBA3421428155699D51E4CFE2022D9DCA@IRSMSX103.ger.corp.intel.com>
<20150731103430.GA16823@hmsreliant.think-freely.org>
<55BED47A.8030001@linux.vnet.ibm.com>
In-Reply-To: <55BED47A.8030001@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 15080303-0033-0000-0000-000001E773C9
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Aug 2015 03:46:43 -0000
Confirmed. It can compile on Power8 Big Endian.
Thank you!
On 2015/8/3 10:39, Chao Zhu wrote:
>
> Really sorry for the delay.
> Originally, I thought the email was to asking the ABI checking tools
> on Power which I'm not so familiar with. So this took me some time to
> find solution. For Power little endian, the build is OK. I'll give
> feedback when I tried Big endian compilation.
>
> On 2015/7/31 18:34, Neil Horman wrote:
>> On Fri, Jul 31, 2015 at 09:03:45AM +0000, Mcnamara, John wrote:
>>>> -----Original Message-----
>>>> From: Neil Horman [mailto:nhorman@tuxdriver.com]
>>>> Sent: Monday, July 13, 2015 3:00 PM
>>>> To: Mcnamara, John
>>>> Cc: dev@dpdk.org; vladz@cloudius-systems.com
>>>> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
>>>>
>>>> On Mon, Jul 13, 2015 at 10:47:03AM +0000, Mcnamara, John wrote:
>>>>>> -----Original Message-----
>>>>>> From: Neil Horman [mailto:nhorman@tuxdriver.com]
>>>>>> Sent: Monday, July 13, 2015 11:42 AM
>>>>>> To: Mcnamara, John
>>>>>> Cc: dev@dpdk.org; vladz@cloudius-systems.com
>>>>>> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
>>>>>>
>>>>>> On Mon, Jul 13, 2015 at 11:26:25AM +0100, John McNamara wrote:
>>>>>>> Fix for ABI breakage introduced in LRO addition. Moves lro
>>>>>>> bitfield to the end of the struct/member.
>>>>>>>
>>>>>>> Fixes: 8eecb3295aed (ixgbe: add LRO support)
>>>>>>>
>>>>>>> Signed-off-by: John McNamara <john.mcnamara@intel.com>
>>>>>>> ---
>>>>>>> lib/librte_ether/rte_ethdev.h | 4 ++--
>>>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>>
>>>>>>> diff --git a/lib/librte_ether/rte_ethdev.h
>>>>>>> b/lib/librte_ether/rte_ethdev.h index 79bde89..1c3ace1 100644
>>>>>>> --- a/lib/librte_ether/rte_ethdev.h
>>>>>>> +++ b/lib/librte_ether/rte_ethdev.h
>>>>>>> @@ -1578,9 +1578,9 @@ struct rte_eth_dev_data {
>>>>>>> uint8_t port_id; /**< Device [external] port
>>>> identifier.
>>>>>> */
>>>>>>> uint8_t promiscuous : 1, /**< RX promiscuous mode ON(1) /
>>>> OFF(0).
>>>>>> */
>>>>>>> scattered_rx : 1, /**< RX of scattered packets is ON(1)
>>>> /
>>>>>> OFF(0) */
>>>>>>> - lro : 1, /**< RX LRO is ON(1) / OFF(0) */
>>>>>>> all_multicast : 1, /**< RX all multicast mode ON(1) /
>>>> OFF(0).
>>>>>> */
>>>>>>> - dev_started : 1; /**< Device state: STARTED(1) /
>>>> STOPPED(0).
>>>>>> */
>>>>>>> + dev_started : 1, /**< Device state: STARTED(1) /
>>>> STOPPED(0).
>>>>>> */
>>>>>>> + lro : 1; /**< RX LRO is ON(1) / OFF(0) */
>>>>>>> };
>>>>>>>
>>>>>>> /**
>>>>>>> --
>>>>>>> 1.8.1.4
>>>>>>>
>>>>>>>
>>>>>> I presume the ABI checker stopped complaining about this with the
>>>>>> patch, yes?
>>>>> Hi Neil,
>>>>>
>>>>> Yes, I replied about that in the previous thread.
>>>>>
>>>> Thank you, I'll ack as soon as Chao confirms its not a problem on
>>>> ppc Neil
>>> Hi Chao,
>>>
>>> Any reply on this.
>>>
>>> Neil, if there is no reply to this from the PPC maintainer do you
>>> have any objection to this going in as is.
>>>
>>> It at least fixes the LRO ABI breakage on the platforms we can test on.
>>>
>>> John
>>>
>> Well, I suppose at this point the only thing its hurting is ppc, so
>> no, no
>> objections. But its pretty disheartening for an arch maintainer to
>> dissappear
>> so soon after adding arch support.
>>
>> Neil
>>
>