From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id D2B11A10 for ; Mon, 10 Aug 2015 07:31:55 +0200 (CEST) Received: by pabyb7 with SMTP id yb7so98456869pab.0 for ; Sun, 09 Aug 2015 22:31:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=yFOtZ0dapyADHadcEXBhu2nVa2qfNjhN+yuH0XRP1O4=; b=ObMY3PutvFSB6CUGik0go2rN9lufMl884W21r/G2CHSa+Cj+u+bL4ZoJ6pOqxpfs6p StkK4seIZgEkNXb5TlsEkdY7AUz1t2pH5NpLtrOTudwfNwPoIehzaoyW2k0nZVgkNkNh +LlD3FflIYuaW544YVb8jjIzmn7iMMxmLl8gboTkm03ghHuyldpjo1y4qIVslupt36cz fFlQ9ZYoErLWMCu+LntWFkwlFyIfeT4cElcSgvCPGTWzcK8L/J3FMFOHPs1uxBTaE1Jd bylO+L2iP/QwsU1SimaI+SqoaaBLkvFOslaLGhJRp1ouLwCoC7XrnbdMA8OHEJAVNFJn tMpA== X-Gm-Message-State: ALoCoQnTAfopBNYhMmDPGu2sEXV7cTZxV8nzrOfzxvmF6UBGOm4/kS/Qj4oP92z9ZE1Fy9oJAQ64 X-Received: by 10.66.148.136 with SMTP id ts8mr41883350pab.15.1439184715041; Sun, 09 Aug 2015 22:31:55 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id nh3sm18322270pdb.72.2015.08.09.22.31.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Aug 2015 22:31:54 -0700 (PDT) Message-ID: <55C83747.7080902@igel.co.jp> Date: Mon, 10 Aug 2015 14:31:51 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ravi Kerur References: <1438884241-15599-1-git-send-email-rkerur@gmail.com> <55C41735.1030405@igel.co.jp> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v1] Change rte_eal_vdev_init to update port_id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2015 05:31:56 -0000 On 2015/08/08 7:06, Ravi Kerur wrote: > Hi Tetsuya, > > On Thu, Aug 6, 2015 at 7:25 PM, Tetsuya Mukawa > wrote: > > On 2015/08/07 3:04, Ravi Kerur wrote: > > diff --git a/drivers/net/enic/enic_ethdev.c > b/drivers/net/enic/enic_ethdev.c > > index 8280cea..472ef5a 100644 > > --- a/drivers/net/enic/enic_ethdev.c > > +++ b/drivers/net/enic/enic_ethdev.c > > @@ -36,8 +36,8 @@ > > #include > > #include > > > > -#include > > #include > > +#include > > #include > > #include > > Hi Ravi, > > Do we need this fixing? > > > > > diff --git a/drivers/net/mpipe/mpipe_tilegx.c > b/drivers/net/mpipe/mpipe_tilegx.c > > index 743feef..6e3e304 100644 > > --- a/drivers/net/mpipe/mpipe_tilegx.c > > +++ b/drivers/net/mpipe/mpipe_tilegx.c > > @@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname, > > if (!eth_dev) { > > RTE_LOG(ERR, PMD, "%s: Failed to allocate > device.\n", ifname); > > rte_free(priv); > > + return -ENOMEM; > > How about separating this fixing from the patch, and put it as an > one of > cleanup patch series? > > > rte_pmd_mpipe_devinit is the init func pointer called via > rte_eal_vdev_init. Since we were fixing rte_eal_vdev_init thought of > taking care of mpipe issue. If you think it's unrelated to this patch > I will send a separate one. > Hi Ravi, To avoid segmentation fault like above has a point, even if rest of this patch won't be applied. So I guess it's nice to separate the patch. Thanks, Tetsuya