From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 460038D3A
 for <dev@dpdk.org>; Wed, 12 Aug 2015 10:24:25 +0200 (CEST)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 by mx1.redhat.com (Postfix) with ESMTPS id 9A5F519F277;
 Wed, 12 Aug 2015 08:24:24 +0000 (UTC)
Received: from dhcp195.koti.laiskiainen.org (vpn1-4-133.ams2.redhat.com
 [10.36.4.133])
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 t7C8ONmZ030008; Wed, 12 Aug 2015 04:24:23 -0400
To: Ouyang Changchun <changchun.ouyang@intel.com>, dev@dpdk.org
References: <1434355006-30583-1-git-send-email-changchun.ouyang@intel.com>
 <1439366567-3402-1-git-send-email-changchun.ouyang@intel.com>
 <1439366567-3402-4-git-send-email-changchun.ouyang@intel.com>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <55CB02B7.8040900@redhat.com>
Date: Wed, 12 Aug 2015 11:24:23 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <1439366567-3402-4-git-send-email-changchun.ouyang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
Subject: Re: [dpdk-dev] [PATCH v4 03/12] vhost: update version map file
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Aug 2015 08:24:25 -0000

On 08/12/2015 11:02 AM, Ouyang Changchun wrote:
> From: Changchun Ouyang <changchun.ouyang@intel.com>
>
> it is added in v4.
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> ---
>   lib/librte_vhost/rte_vhost_version.map | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> index 3d8709e..0bb1c0f 100644
> --- a/lib/librte_vhost/rte_vhost_version.map
> +++ b/lib/librte_vhost/rte_vhost_version.map
> @@ -18,5 +18,5 @@ DPDK_2.1 {
>   	global:
>
>   	rte_vhost_driver_unregister;
> -
> +	rte_vhost_qp_num_get;
>   } DPDK_2.0;
>

Version map needs to be updated along with the actual code (in this 
case, the function is added in the second patch of the series). 
Otherwise there will be at least one commit where shared library 
configuration will be incorrect and might not be buildable at all.

- Panu -