Re: [dpdk-dev] [PATCH] mbuf & mempool: explicit typecast on function return

[Olivier MATZ <olivier.matz@6wind.com>]

Hi Joongi,

On 08/17/2015 02:28 PM, Joongi Kim wrote:
> I already have fixed this issue
> at http://dpdk.org/dev/patchwork/patch/6068/ .
> There is another issue related to "underlying type" for enum
> declarations http://dpdk.org/dev/patchwork/patch/6067/, for C++11 compilers.
> 
> In the second patch I missed updating headers for architectures other
> than x86,
> so it needs to be updated before applying to the master branch.
> 
> It would be great for me to have this fixed on the master branch,
> as I am manually applying above patches whenever I pull the latest codes.
> 

+CC Thomas.

Sorry, I missed your previous patches. I think it would indeed be
helpful to have them included before the release to allow compilation
of C++ programs.

I'm wondering if we should add a C++ example in dpdk/examples: people
would see the problem before commiting, or if they miss it, I know some
people are doing automatic compilation tests every day.

Regards,
Olivier



> Regards,
> Joongi
> 
> 2015년 8월 17일 (월) 오후 5:15, Olivier MATZ <olivier.matz@6wind.com
> <mailto:olivier.matz@6wind.com>>님이 작성:
> 
>     Hi Sergey,
> 
>     On 08/12/2015 11:11 AM, Sergey Balabanov wrote:
>     > When DPDK is being compiled in C++ project using g++ then
>     > 'invalid conversion from' error appears. Added explicit
>     > typecast on function return to get rid of the error.
>     >
>     > Signed-off-by: Sergey Balabanov <balabanovsv@ecotelecom.ru
>     <mailto:balabanovsv@ecotelecom.ru>>
> 
> 
>     Fixes: 7755baae8378 ("mbuf: silence warning on pointer arithmetic")
>     Fixes: 6cf14ce4ce6c ("mempool: silence warning on pointer arithmetic")
> 
>     Acked-by: Olivier Matz <olivier.matz@6wind.com
>     <mailto:olivier.matz@6wind.com>>
> 
>     Thanks
>