From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id A40888DA0
 for <dev@dpdk.org>; Mon, 17 Aug 2015 14:51:08 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128)
 (Exim 4.80) (envelope-from <olivier.matz@6wind.com>)
 id 1ZRJxX-0002UN-LT; Mon, 17 Aug 2015 14:56:19 +0200
Message-ID: <55D1D8B1.1090604@6wind.com>
Date: Mon, 17 Aug 2015 14:50:57 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version: 1.0
To: Joongi Kim <joongi@an.kaist.ac.kr>, 
 Sergey Balabanov <balabanovsv@ecotelecom.ru>, dev@dpdk.org
References: <1439370664-25728-1-git-send-email-balabanovsv@ecotelecom.ru>
 <55D197E8.5040501@6wind.com>
 <CAKOGY8+fxBoySfyWvH4u_eDVrKqFstBC+pNzBXXNjiXLzHT3cw@mail.gmail.com>
In-Reply-To: <CAKOGY8+fxBoySfyWvH4u_eDVrKqFstBC+pNzBXXNjiXLzHT3cw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] mbuf & mempool: explicit typecast on
 function return
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Aug 2015 12:51:08 -0000

Hi Joongi,

On 08/17/2015 02:28 PM, Joongi Kim wrote:
> I already have fixed this issue
> at http://dpdk.org/dev/patchwork/patch/6068/ .
> There is another issue related to "underlying type" for enum
> declarations http://dpdk.org/dev/patchwork/patch/6067/, for C++11 compilers.
> 
> In the second patch I missed updating headers for architectures other
> than x86,
> so it needs to be updated before applying to the master branch.
> 
> It would be great for me to have this fixed on the master branch,
> as I am manually applying above patches whenever I pull the latest codes.
> 

+CC Thomas.

Sorry, I missed your previous patches. I think it would indeed be
helpful to have them included before the release to allow compilation
of C++ programs.

I'm wondering if we should add a C++ example in dpdk/examples: people
would see the problem before commiting, or if they miss it, I know some
people are doing automatic compilation tests every day.

Regards,
Olivier



> Regards,
> Joongi
> 
> 2015년 8월 17일 (월) 오후 5:15, Olivier MATZ <olivier.matz@6wind.com
> <mailto:olivier.matz@6wind.com>>님이 작성:
> 
>     Hi Sergey,
> 
>     On 08/12/2015 11:11 AM, Sergey Balabanov wrote:
>     > When DPDK is being compiled in C++ project using g++ then
>     > 'invalid conversion from' error appears. Added explicit
>     > typecast on function return to get rid of the error.
>     >
>     > Signed-off-by: Sergey Balabanov <balabanovsv@ecotelecom.ru
>     <mailto:balabanovsv@ecotelecom.ru>>
> 
> 
>     Fixes: 7755baae8378 ("mbuf: silence warning on pointer arithmetic")
>     Fixes: 6cf14ce4ce6c ("mempool: silence warning on pointer arithmetic")
> 
>     Acked-by: Olivier Matz <olivier.matz@6wind.com
>     <mailto:olivier.matz@6wind.com>>
> 
>     Thanks
>