From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 9C80E5A0F for ; Thu, 20 Aug 2015 04:07:09 +0200 (CEST) Received: by padfo6 with SMTP id fo6so9867466pad.0 for ; Wed, 19 Aug 2015 19:07:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=72LPLLQEdK/hVgT5pQTzC5BXMLabtsVbe3w2LVIvPYo=; b=ORTE6frd31mF6V0VIaienj2BVGqEKRAzUMj6JxQd4WQ43IkdGb4R6YIMDXHUji5uot ewVq9ND4j7bYaJmrZqBY9fUD7gzeq0eO3dvI47pisjHhxkUw4vWQcG53iCqz/IOgwcsg VZXdM6fn5aflPmhpNY/Dy2PCgHlP736Oe/2k1rLoXVu7Zs3suvG4h5zoo+sM9QPjzGQL uQ8u54HdIodKvoz+0TyPv93H65+c58pyxoTGS6bdJqzmOz9na2P18SBLqlc9NX/ztsKn Ak2v+bHuY8i0YscSyVTYsxQ2w773vASqHIk2NAiO78USuChKpw9oiTtsrYTVLfRAXTWp ac/A== X-Gm-Message-State: ALoCoQn48oigTeazHSGXATz4e1897znv9/5rASnLtrX4sLz/A7MO1VAa6lpXocZrEhwjcet0u63x X-Received: by 10.66.196.15 with SMTP id ii15mr1423843pac.108.1440036428696; Wed, 19 Aug 2015 19:07:08 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id ay10sm2310693pbd.13.2015.08.19.19.07.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Aug 2015 19:07:07 -0700 (PDT) Message-ID: <55D53649.7040901@igel.co.jp> Date: Thu, 20 Aug 2015 11:07:05 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ravi Kerur , "dev@dpdk.org" References: <1440014407-3233-1-git-send-email-rkerur@gmail.com> In-Reply-To: <1440014407-3233-1-git-send-email-rkerur@gmail.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Aug 2015 02:07:10 -0000 On 2015/08/20 5:00, Ravi Kerur wrote: > In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate > fails return error which is inline with other drivers. > > Signed-off-by: Ravi Kerur > --- > drivers/net/mpipe/mpipe_tilegx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/mpipe/mpipe_tilegx.c b/drivers/net/mpipe/mpipe_tilegx.c > index 743feef..6e3e304 100644 > --- a/drivers/net/mpipe/mpipe_tilegx.c > +++ b/drivers/net/mpipe/mpipe_tilegx.c > @@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname, > if (!eth_dev) { > RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n", ifname); > rte_free(priv); > + return -ENOMEM; > } > > RTE_LOG(INFO, PMD, "%s: Initialized mpipe device" Acked-by: Tetsuya Mukawa