From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from APC01-PU1-obe.outbound.protection.outlook.com (mail-pu1apc01on0124.outbound.protection.outlook.com [104.47.126.124]) by dpdk.org (Postfix) with ESMTP id 9A8BF5A58 for ; Tue, 1 Sep 2015 10:10:13 +0200 (CEST) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=jiaxt@sinogrid.com; Received: from [0.0.0.0] (107.170.235.12) by SIXPR04MB0762.apcprd04.prod.outlook.com (10.162.175.21) with Microsoft SMTP Server (TLS) id 15.1.256.15; Tue, 1 Sep 2015 08:10:03 +0000 From: =?UTF-8?B?6LS+5a2m5rab?= To: "Lu, Wenzhuo" References: <1441088490-9420-1-git-send-email-jiaxt@sinogrid.com> <6A0DE07E22DDAD4C9103DF62FEBC0909D4282A@shsmsx102.ccr.corp.intel.com> Message-ID: <55E55D51.10201@sinogrid.com> Date: Tue, 1 Sep 2015 16:09:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909D4282A@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [107.170.235.12] X-ClientProxiedBy: SIXPR04CA0024.apcprd04.prod.outlook.com (25.162.171.14) To SIXPR04MB0762.apcprd04.prod.outlook.com (25.162.175.21) X-Microsoft-Exchange-Diagnostics: 1; SIXPR04MB0762; 2:9wVWR2co0cP8UoZ7OrM5hjM6VJO9tZtMeps4tMwrVZYkE5UlNNTVJZRXeeW9ISb5syr46boOK0FxnTEQ0WujYgMLieabDVwUMeSB5I8zdQaObt4oz9lUTRO8COjPFtXDlUoh444hQtx12zNtaiCehvkaDWaMctyYy3vydRCeipo=; 3:mZPOHYuuTPz34tTxv7QLUV1iCs4Hpc6YZyaxZhoNc8/AtRJDw9nyP5pGyveSetsRKR78jL+LjBWqTED6OQwuZ1wHQSxyxYeQfeyQ/upZ9/6fslnamGrDx1PJswnYlBmvax/JnMIst0AwV0hNVlmmdA==; 25:oH9tNj5npbkhRjhDEfa6Szl8qqskIIfDSjz5Z3w6LImog+tFWrAfyEkRv+WuV8h1WlWAQ/hxAT0fD2S28jvmzw4foh74Ax2tGwadmMjqzaULyRk8w6XpsZX0y+MLGuJDpPNClfz1Zw5xFwTczeXH+uVT8c/BlrNia5WHoYYQLCkN12+JQ5roqHz/wWHmJiYFp1zbse5yTLi+x2YuksXIQeirM701Qce4qINDJtymD1Oc2m3xoArCZx6QJd3VaA0ZMTE31GznEmElRTGZI1Dp1A==; 25:oaTQk+hFdlOn0GRPWtJmGiG+Gi4xl/eCeFVf9HknUDshiTcUjNwrK9brSRgMAS0/TBZdCijumvinF47N0xSUZpXReXfl6ubPZk3s8CpFY3x66BnXFMjRcVA+ueR5rITAN+SPYfh3/jH7rgoy7R4JEVLenSyacqLmJ4hM3KDBpuuWN474KKCv0mTamq9uz8PG3C6BEsQRQUKqUdpneC6um4jo89c88d0DNq7+K1E3W92QbaC29IFrn/qwJaJOGSTCgCNRd8NNWIOF6ccUvoQ9LQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SIXPR04MB0762; X-Microsoft-Exchange-Diagnostics: 1; SIXPR04MB0762; 20:2ItenCOE/tCP44iCFTd2sbFb6+V+gJTZB8JQAidpRKtwFP841RYYFJbtZmkDJMpljrW7A2v14bVuScC+P/WZESh+X4lL3ith/Eq5Z+GZBMDTzRd/nWfWu5rNRWa2xioQTDV4pbBLcXtzEc5nRMJzKahjhbMVQ/Y9oSBhhbwMf3tp+l84+hIBcwkJfgl1Jh7Om2VWE8+SvlUX7gkyHuHjhCfA6H6zJ9/rnglerFZJDSfK5//HxbNcc9O17uKtdqoXYy2Jt3cKy2gFOv8LOwt2z+Z/UWXLK++XotKPEio7K45YJ9hmQ14+npVslh5i8zdDaX5lEStv0e0E54KDejGkHuayjz3wklMJZIwNQ9J7M10rATKkSG+g49pB1h3fzeR09y05GfxjTFvWNoNrLMhpTxHcMlAzBo0kDKzvxzdhCw7ep77i2OkplaMtjlGIY1w17Ii9RHd2CJl5GPWArd1N7PjkiI2H6ZrA3nKMpjhMv3GjIUVr0nOucq86g/1+kJMn; 4:p6zE88js7ghgmH4Z8CWPLyL+HoqVHsqk6Iv9xVA5jFc5g1dN3gKlnf5PRg1ChHsWeUJz3vp35VXhBbA9uDJBeRRSbykvn6USrqR1HkmUvlfsZ40LxmC2mXPznzUzb7NKr6sVfRhVQkxZZn9pfJ9I4+sa68DiulI6I5v11pBngWkT7gpLRDZHPXmeMZgbNFRGTfdibEtKDTDTq2WD3mrHZ1Z5zwchsuzVwaF5AFYAHZ+sDkpnTsBFXUsFH/7fs23qzgHdqfqJrcqxRx7fyeq1IBheZC+Ng/aSXrQsTf1Jo7lQ4GG/ceN0ZqvY4ZstC51E7oxT32+CAFvPdtp9TJi5EQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(8121501046)(5005006)(3002001); SRVR:SIXPR04MB0762; BCL:0; PCL:0; RULEID:; SRVR:SIXPR04MB0762; X-Forefront-PRVS: 06860EDC7B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(6049001)(189002)(199003)(479174004)(24454002)(377454003)(13464003)(5001960100002)(122386002)(36756003)(65816999)(65956001)(47776003)(50986999)(85182001)(42186005)(66066001)(83506001)(2950100001)(101416001)(54356999)(46102003)(105586002)(64706001)(86362001)(64126003)(23676002)(19580405001)(19580395003)(92566002)(65806001)(87976001)(106356001)(81156007)(5001860100001)(110136002)(50466002)(33656002)(4001540100001)(76176999)(40100003)(97736004)(5001920100001)(5004730100002)(68736005)(189998001)(5007970100001)(77156002)(77096005)(62966003)(4001350100001)(5001830100001)(7099028)(21930200001)(28096002); DIR:OUT; SFP:1102; SCL:1; SRVR:SIXPR04MB0762; H:[0.0.0.0]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: sinogrid.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTSVhQUjA0TUIwNzYyOzIzOjJGSGVtbnU3aFZHd2NPLzZDNFBNRngydFJT?= =?utf-8?B?ZW5XK0UvMUkzMTNCcWtSRkFMbXpKOGU4WTFLOXZkSEQ3YUFVa09RRlg0WkNj?= =?utf-8?B?N1ZpYTg4bjMvV3lsSnRKbDZHNzZHYzhDOVIzejhzdDMvT2VxWE1WcTBPdGdw?= =?utf-8?B?M3luazhmempCcHBhcFh4dVV2dG1yQ2IrdC94SWIzWDJjdVdBOTBNSlo4aUEw?= =?utf-8?B?azNBWXBBWlh1Y0h6RTBFVW9KQ1dRLzF3aGN5N0ZMWU5zY2tSeElINjBpZStM?= =?utf-8?B?aHVidHNDekwvaEVGcCtVYmlqd05xSGVTRUJ1UHpyL0FHSXJDUTM1Yk5sKzhV?= =?utf-8?B?d2I2QjZkc3ZmR2ZQOE45OU9sR0hzdmRZSENFN2p6d2ptYUtaQTVhRGRSVmZO?= =?utf-8?B?RDlRb0VhQkg1aURmbW0xVzFLMng2TkswU1pvSG5ieVNybHlPK1NXYmxHVTgw?= =?utf-8?B?RkZ3QWlRTXk3QTFsU0w0dFlkZGw2eGt4SURMRXAvUmtnSTJvdHM2K3NqK29T?= =?utf-8?B?RCs2dUtuQ0w5b0VjVlFzN2dpb2hpQTVDOC9zT1dDblVyeHNFTUNxZmpmQ2VW?= =?utf-8?B?emQ1V1JXYmtheWVSZnU0bk1YRWZOZUhJU3pmUDN0aXJ6c05DTzluQytQdWNT?= =?utf-8?B?c1ZTK21Ra1lMaEF0Y0JxQ1BIRHYzSVltdjVibEVzMVNNWWZ5clcwK1VZQzRj?= =?utf-8?B?d2NHR1BxdHliem1tK2RWaUs5dkhkQ051eTNsSWV5MEtKeTNOR3lwRkpsV2hl?= =?utf-8?B?YnVENVd3QTVDdndLU3lybCtsYlhJak9IOTN3M0dSN0huakVEL25ZVUp6MUlj?= =?utf-8?B?aklKY1NLaFQ1NWEvQkZ6b3lBdmtWRzdkWEZ2RVVGZlU5K1U4V3BGOXdMWWZa?= =?utf-8?B?RS81Q0N0RU40dVl5a2JvQW1kUXZpTktMYnA0bHZ1WGpobmFKOHBVWUZDeEpL?= =?utf-8?B?SzczMWlCQmtKU2hBaVBXTVprbmJFczE2YUJEZFVBWEVvaE5uRFRlN3kwNVJO?= =?utf-8?B?Q1cvWkFTZzczdWFVSzhWVXJKNTNtazVQTnlZUENsNmV1alExVjNsNkMzWHFT?= =?utf-8?B?NXV5U2J2akk0RDBkZFUyZDBFUUVXL0pKT29vVGJRcWQvODcxd0xhbm9EUDNG?= =?utf-8?B?UFRvS3VLWHNlTFJITklXcnRHUjIycVBWSXZnaWMvMUNvczN3Y3E0OTlzMzhT?= =?utf-8?B?WC84cXNDWGNoanJuU3BRaE9iZU5JL01oNzhNUXZlSkhvSk9XcmEza1hCTVJn?= =?utf-8?B?dTFYQ1o5OTFQNjZ1UWQ1eUMwQ0VxMTBRV09uVmprZWJYZkladDc1dkRuK0Za?= =?utf-8?B?aUE5blluV3d6Z0NObjZDcVNKYXlkOTY4YzBwSXZLaXhVWlIwTytIenJ6Tlpy?= =?utf-8?B?ZHlaQlFwRVNBd0IrWFZZbGFFbnB6NnQvN0drc0NaTG1UaWJFMUJMemRJcTdx?= =?utf-8?B?eTlvRVNLcXp6bnMwVjVFZzNOL0JVUjFodUFrSVRKbVNMYmpEV3JoejlBVW9w?= =?utf-8?B?VGdndyt4MitTMUN1OFgzRHFSaVJmN1R0U3RvWFJCc2JRaWhzMzg0ZTNqZHk4?= =?utf-8?B?cktGSFh2MU9oUDNIWkdpMDJGUTdGeFVUOHc0RmpaRFlzR2p2VnVZem1LdkNS?= =?utf-8?B?TkRrT3B0eTNiRDRXaXNrRENRU0M0LzlqLzZNL2pTY0VtL3RJVzMrc0pIK2lY?= =?utf-8?B?a1hESkhlZHNGY3FGL0VPOUVzNW9zV05Wa2dDak1Od1ZYNlFYNi9LazhpbE9T?= =?utf-8?B?UUhBaFNOZ1NxMExNL0J2angyR2FnbHlIWDdNcXFNZENmTXNMM2QzeG9MRm5s?= =?utf-8?B?U2lWeVVpZTB3ejZHVEo5VzFHZzI5TGNCSXNETjNMaUczaTY0MTgvNTk2ZUVG?= =?utf-8?B?dktCQk93RFJieE1vZytxbzZmbERNeU9jZmJ5b2lNdEo4K2FXaHdoSFR1NFdq?= =?utf-8?B?VWphQVJVd1hzRFFGbDg4c0RDT3FUeDRBT0U3bzNmNkVWdlZPbm80elkzUnFv?= =?utf-8?Q?FI4JPH?= X-Microsoft-Exchange-Diagnostics: 1; SIXPR04MB0762; 5:poAGZ3mZVTVp5pmUOkLJU9G5Q4VxG9uSFAQRQfhPFBYAoqA7o3IDRb8LDbzszJhITfLjG3OnRD5ZcN6rYpjrRtVqRjnjanPEpCs0T4kcD3q6YQqUNqvi2Z53i9AHglADDECpUSJZEYOtVuyKektc1w==; 24:QfnhcGNUy9LGs649mdFV+ISPiDnOyPELC73WrD1RcFO0RwOmobU2t6uMu10VYqts6bIg5xCm1hWk8QHSso86xe20svqWlAV4arqEZvhyO1Q=; 20:/VfojaYcX/JzWpBe8KUdHNRAMWOAOXhsciI+cqvgHgPXh17oO6gzEEelvgmc3rfzTz2QdK0x6+ys/mCor30S0A== X-OriginatorOrg: sinogrid.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2015 08:10:03.4703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SIXPR04MB0762 Cc: "dev@dpdk.org" , "letaotor@gmail.com" Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix LSC callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2015 08:10:14 -0000 Hi Wenzhuo, I bond 82599 ports with mode 802.3ad, the bonding port can't work properly. But bonding with i350 ports works properly. I found the registered callback function bond_ethdev_lsc_event_callback by __eth_bond_slave_add_lock_free was not executed when link status changed. I compared ixgbe driver with igb driver, ixgbe's LSC interrupt action without _rte_eth_dev_callback_process. On 09/01/2015 03:42 PM, Lu, Wenzhuo wrote: > Hi Shelton, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shelton Chia >> Sent: Tuesday, September 1, 2015 2:22 PM >> To: dev@dpdk.org >> Cc: letaotor@gmail.com >> Subject: [dpdk-dev] [PATCH] ixgbe: fix LSC callback >> >> add _rte_eth_dev_callback_process to call callback func > Would you like to give more details about why we need this patch? Thanks. >> Signed-off-by: Shelton Chia >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >> index b8ee1e9..4e4c118 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -2775,6 +2775,8 @@ ixgbe_dev_interrupt_action(struct rte_eth_dev *dev) >> >> ixgbe_dev_link_status_print(dev); >> >> + __rte_eth_dev_callback_process(dev, >> RTE_ETH_EVENT_INTR_LSC); >> + >> intr_enable_delay = true; >> } >> >> -- >> 2.5.0 -- 贾学涛 信诺瑞得西安研发中心