From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from APC01-PU1-obe.outbound.protection.outlook.com (mail-pu1apc01on0110.outbound.protection.outlook.com [104.47.126.110]) by dpdk.org (Postfix) with ESMTP id B73715A41 for ; Tue, 1 Sep 2015 10:39:18 +0200 (CEST) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=jiaxt@sinogrid.com; Received: from [0.0.0.0] (107.170.235.12) by SIXPR04MB0761.apcprd04.prod.outlook.com (10.162.175.20) with Microsoft SMTP Server (TLS) id 15.1.256.15; Tue, 1 Sep 2015 08:39:07 +0000 From: =?UTF-8?B?6LS+5a2m5rab?= To: "Lu, Wenzhuo" References: <1441088490-9420-1-git-send-email-jiaxt@sinogrid.com> <6A0DE07E22DDAD4C9103DF62FEBC0909D4282A@shsmsx102.ccr.corp.intel.com> <55E55D51.10201@sinogrid.com> Message-ID: <55E56422.8090008@sinogrid.com> Date: Tue, 1 Sep 2015 16:38:58 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55E55D51.10201@sinogrid.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [107.170.235.12] X-ClientProxiedBy: SG2PR04CA0061.apcprd04.prod.outlook.com (25.169.49.157) To SIXPR04MB0761.apcprd04.prod.outlook.com (25.162.175.20) X-Microsoft-Exchange-Diagnostics: 1; SIXPR04MB0761; 2:9iNs8FdpSm1/mO6ENKqXfW8qJqtqRj+v+2AXk5Eph03MDg5iJKHRosWEVB978fpksrmM+Nz0vzMkaiIEAEy+JLSWX+3S8FbjxZc5d3XeuoVbNK0CRi5w4YZ5xqMSLeyENmxz38HrFWxGVrzu8Vj3O14HUCsUylqpS9sN+wGQV6s=; 3:SXZapBCrjCNCiODF0hXNtRfsgqpGexMU2PBOZPN0fVkwXUkPi4gd8cERaO6CscI3wfaf+Aq6DePmDkEulcYtTd1Q1KA1hH247QhmPu2txVfHVNRE/V1M5OqzjyN+qF/bRLWLtfcZUyQnBdTp8qylkA==; 25:+PfmApXwtnnIgaj8t0J5MN5P0HU0xBmn4HoFHUiQDsw9mP2Fg3sq9fBA48PJjQnhwpkAuNgXYgA6QYnMgn6gJd5rP5HSoJtgzzqb8T36f3j5HW0OtVh2IAXFElKfbrvvws+y5BY0mplIP+DzmODhJSGgJTJIeuLIlk/WV6mOfxqANW/YN6qHV5C2oZQ6LNogu/WP3yMK9XhpxLGdiNxnvf/wOuwlyI3vTEbiBMdeI61QXYvd5kyUAD+KCWo5yEBS6zlcwtkbcMxyjxIzwhwXDQ==; 25:/nTO7HCLOrqLIX8T8QJCatDgB9qmLL5/Ze/gcR6eXB2aMWKhe/5qPm44vpjI8l8qPWk6VIB04V65RfqS45pD7I3LxMue1X5Aomu/o0DtUABIKtXNajhOvDKVvB2qz1ic5klyOlJ4dX63LKqlKKxawik9cgDt57dwnIXWm0LYbFyxA+M1QqS2qJvN8PUTNZimpFuVKcdQTSeO1f+oSTFuRNY5mEWf4WO/zT9yPuLJtW3PvpJLBPsqsjW0hkvH3cOI3GPz/bRzV1BQ12NgHC6jXg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SIXPR04MB0761; X-Microsoft-Exchange-Diagnostics: 1; SIXPR04MB0761; 20:72U1hOlHr3EGRcyW/CIdK8cHeAA2VV+zKLs/GAr3yclfYIIkX5GZeOoGdNG9dPeqlLopKL38habPQUtovSR0AEnxB9gXqVlmp5kyEVfmVTSvujLyiMnnfih5zA2SHc0sTVXDdqD87O5IiRf+wglNh1PkJP8LJcR7Y0fDZN9BOXfAN9v1wUTqSXLO8uL3TPFpYH2ChaOezG+tAHs+r3DJgv91+KHXaJLAU19xVO0mfom08Ph10OdXehdSeGqvLDOcNUpy78jKNobmSaSDxgYfn+aGMgsVze8V1qHXrjBNjkakkpdBuqNWoMZhix1CD14CXdprDQ1CE9rBoBnQRMykyeCodMuQSkCeaoSwQk18Y7CNzInN5u9KpSSDYy10KBnM1wdsUQ7P76xuxg9sjpwNZsipHDTff9P6EFHa3umSYcfdYJIMNpjo2Im5vYWFaUVSE9cUgLfuHVJ+sZtu0fk6DFo/3IQECJfqVOa7CeNPNf/KqN3FiEn89YdEnpsBcR/D; 4:pVmRgYg/Q/CKtMC0Y6qptipa/pwhh8Vu1QHYfGYgY02CriI7MJgWye4fYAiUQYmTzIYK5Eau1YbeLSFRlSlRuvqlS8hnY0r1wu01pSoGcWBo3Yrs6dFSDooEWk+ie47KN6N07cA84aYio10+Vt4Vvs8p8uRTbpZngnFyFrgzDDWOI4P3bkMhumc2d6XrEQZXdGu7AuGVBOetxhUOopFr8UC691yHid8yC1MuEHITZ6rzSwJ2HFPRnMMtEwfG0d4Zprh9pQYyg/f+pbeUWc16TKgIdkLaBPl1bceNZKGuplSNUqI6NIHDQRsQAE/r1OqgSFz70XyFiEJNVEkQ5Svj2A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(8121501046)(5005006)(3002001); SRVR:SIXPR04MB0761; BCL:0; PCL:0; RULEID:; SRVR:SIXPR04MB0761; X-Forefront-PRVS: 06860EDC7B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(6049001)(377454003)(13464003)(24454002)(479174004)(199003)(189002)(47776003)(65806001)(5007970100001)(46102003)(33656002)(5001860100001)(81156007)(50466002)(189998001)(64706001)(110136002)(105586002)(106356001)(36756003)(97736004)(19580405001)(5001960100002)(4001540100001)(4001350100001)(40100003)(77156002)(5001830100001)(62966003)(77096005)(59896002)(68736005)(5004730100002)(85182001)(65956001)(101416001)(64126003)(42186005)(50986999)(76176999)(87266999)(54356999)(83506001)(65816999)(87976001)(23676002)(19580395003)(122386002)(66066001)(80316001)(92566002)(86362001)(2950100001)(7099028)(21930200001)(28096002); DIR:OUT; SFP:1102; SCL:1; SRVR:SIXPR04MB0761; H:[0.0.0.0]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: sinogrid.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTSVhQUjA0TUIwNzYxOzIzOmNIRnVYb3ZWN2NxbnIwS2pWZUlPWFB5aHhD?= =?utf-8?B?N2xlanY2YWNUdzQ4WFF6UnZlSitCd3QzR2gweGxWL1FqNEFYQ3ZZYWx3VHVE?= =?utf-8?B?VXpvalgvOVM2L2Z2eitENnYrS3VybERSY0JqbzFDL1RUNDdKbFp5cnZWV3V5?= =?utf-8?B?SEh3ekF4MW9EOWJhUEdqMnJ0dVRLaWlvNVNWUFJYS1JXODdvYjZ2UDNXV0VJ?= =?utf-8?B?Y1NWUnpOY1BMVloyc0pkRmowanNyN2NUK1prUzg1djBub1o0Q1pyaDB4dm45?= =?utf-8?B?eVJ5amMxeWIzRWV4T09uZjBDbjFONUhYVG5oc3Uycm5hVjRUcWt5emFTQjRV?= =?utf-8?B?cUZET1ZJd0pWUFdWQk8zdmtKVHV0T05nQ00zQVJ5bGpaaXFUMWpjWjcvckxa?= =?utf-8?B?aWYrOTh4WmI1V0doQWs2QXkzUHBEOHJETGQ5Z2YxRVNRMTIrTy9vZmsvZCt0?= =?utf-8?B?dThjUkxRQ05aN0hZZzh6TTlnTjlLRkxuWGZLRTdmVzJzYng0R0tHcTFYVkJl?= =?utf-8?B?RDV3YWQ3ZVNEZjRBbDI4VkZJNm4rZHJZM1h1c01mZDBBd1RVWDFFYllzckpP?= =?utf-8?B?b3AxcDMrWkhuM1BHc1ZlM0krc3lmeXpya3R5WEszaDEvdCtjUThyMVB4T1hq?= =?utf-8?B?djcxMm9GcktNK1ExT3BJcGpJN3YvWlg2eE9VeDNRdENTQWdERTIrVnUrUElo?= =?utf-8?B?Q0IvaVVFWTZraEhwSjV1OHkxNklqbG9xSGljU2RFZXRkdWRlcitrVVdHZUU4?= =?utf-8?B?SElSa1J5KzRGemxibk5rVDNVSG5FT3pOOW9ndms5cUxUMFBFa0x4czJKOEJD?= =?utf-8?B?aVpYNmRNQkJtSERLa2ZTR2NhT083cjlSZkJHeWR1L2xkdXEwaWVZd0V0UVVn?= =?utf-8?B?SHZmb0laQWNBQ2RzRHhUVDJtN3lXSUpWMDVGM01BOWFNR0hqY3htaExtMWZP?= =?utf-8?B?SGtwSER6SzBrcmFQREYvRVptMlAxWkMvNTFQM0lCTm5DSXZyQ2xsdHo2NGlY?= =?utf-8?B?a2tPYlVBMFEzSHIyRUs3MmJjTmlUelF0Vis5V05YWGw1Vi9kbmc2L240QVB6?= =?utf-8?B?Y3dIY0h4ellOa0VXdzRTNXBqTVZQV3M5TExlMmdPbitsWW40WVJ0ZHdweHF0?= =?utf-8?B?U2RHMTJ5Zi9HY0h1Uys1aGxBak1sa3lHWG02QnFmK3ArZ00yZm9CNWlzWnc1?= =?utf-8?B?anJDcjlTdGNQUDBWWk9Xcmd3WERETlVlWnEvMTZmbFZLRjg5ZnlyQndqTVFK?= =?utf-8?B?YlVNTkYzUWR2TDNCMmJ5L3lxZnpXT0t6dXJ2V2F3ZUhBbkxtNGVvejFVaUFE?= =?utf-8?B?UzhvcnhxeVZraDR2Y2JqZG8xRDZKa0JnSDN5K2VrSi9oSVhieGRWNElISEFl?= =?utf-8?B?azlRdVpCZlF0a0NiK1pqQ2VzNDlqcXpIUG44eWZESTNyOVBDUktrbHp4TGtM?= =?utf-8?B?ZVFYR1ZOdmhlZ2UrODNGUi9VSCtqS1FVYWloTXlPVGRPZHYxZVRYQ1dWSVYy?= =?utf-8?B?TGlMbFdwT0xkcU1hWi95cUd3MHZlL2tYNjRyT1d3dUQrQ0pzbXE3ZlpMWjJK?= =?utf-8?B?THNsRk01cFdSMmhqUUZ6MERnY05memRsSEJwQzFIRkxaYXRRM2REMEQ2ZWRW?= =?utf-8?B?b3l6Qi9FdEVNdVJSREd0Z2s5cWJUQ1FiTlBuUVRzKzJoaHJIYk4wVWdjQnZp?= =?utf-8?B?RS9FdklRenNmclRqR2J2eFhuZStaNjl2bERYVkZ4eU8xTjQvM3oxUzFuYjY1?= =?utf-8?B?cHpZaUF1SHJRNVRGMFlrSi96a3A4MEtIcTVWdzFVZjVUU3YrSnFiYnREV01t?= =?utf-8?B?SFZsNEx2OGx6TzQ4WXB4VzExT1dTWmRzSWdZbzBBSlNnUDBPWUlGa3JDaVRM?= =?utf-8?B?Z24rVWFOWDFiRXRBWW8rUDFRU2h2QVJyTXZ6VjhaMkhhUjMyYkwwNGJ4OTYy?= =?utf-8?B?MU80dHdNSlIxamNzbVRIL1Z2SUFCVEloYW9rWDF5TmlJcjBMaHV5ODBYa1lC?= =?utf-8?B?TUpzV0dTWktSdGM0eHJpd2xXRnRVd1piRnJ3VEtoQm9qNGd3dWNkdGZ5ajBC?= =?utf-8?Q?baBs=3D?= X-Microsoft-Exchange-Diagnostics: 1; SIXPR04MB0761; 5:YQCU9RwEYXapIvUOZoKGGy9yAwuRbFMaYAyj5nhpk5Mq2qF0RfwvOxXUg8DvopxbVBpiM2skgeztfwyDpxt6RJ1Ee45vLfQQnce/SJgztoJQJs33gkUGZluduab9Lq98hIsK/oYxiNX2DjXFfTlmKw==; 24:g+4zNJWJZhX+3tn14j4mWzYvVBglxHsKdsE8uftCD1hwp0GAJGVEX5VPOkbNYbNP1sQnKPS2jHe/IwM2ASr6SD4rjVcM0xEsMYHZrJ6+JiU=; 20:Sx0r2GVF0JHbW9PMQj/Z67shZRgF3OaMQQjAJc6W2V1BK+SiMEfD5X6HO2lxn13U1Qaxg9LbTW5QnGeDhRWFsg== X-OriginatorOrg: sinogrid.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2015 08:39:07.9457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SIXPR04MB0761 Cc: "dev@dpdk.org" , "letaotor@gmail.com" Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix LSC callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2015 08:39:20 -0000 Hi Wenzhuo, I just noticed _rte_eth_dev_callback_process called by ixgbe_dev_interrupt_delayed_handler. This patch was incorrect, please ignore it. On 09/01/2015 04:09 PM, 贾学涛 wrote: > Hi Wenzhuo, > I bond 82599 ports with mode 802.3ad, the bonding port can't work > properly. But bonding with i350 ports works properly. I found the > registered callback function bond_ethdev_lsc_event_callback by > __eth_bond_slave_add_lock_free was not executed when link status > changed. I compared ixgbe driver with igb driver, ixgbe's LSC > interrupt action without _rte_eth_dev_callback_process. > On 09/01/2015 03:42 PM, Lu, Wenzhuo wrote: >> Hi Shelton, >> >>> -----Original Message----- >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shelton Chia >>> Sent: Tuesday, September 1, 2015 2:22 PM >>> To: dev@dpdk.org >>> Cc: letaotor@gmail.com >>> Subject: [dpdk-dev] [PATCH] ixgbe: fix LSC callback >>> >>> add _rte_eth_dev_callback_process to call callback func >> Would you like to give more details about why we need this patch? >> Thanks. >>> Signed-off-by: Shelton Chia >>> --- >>> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >>> b/drivers/net/ixgbe/ixgbe_ethdev.c >>> index b8ee1e9..4e4c118 100644 >>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >>> @@ -2775,6 +2775,8 @@ ixgbe_dev_interrupt_action(struct rte_eth_dev >>> *dev) >>> >>> ixgbe_dev_link_status_print(dev); >>> >>> + __rte_eth_dev_callback_process(dev, >>> RTE_ETH_EVENT_INTR_LSC); >>> + >>> intr_enable_delay = true; >>> } >>> >>> -- >>> 2.5.0 > -- 贾学涛 信诺瑞得西安研发中心