From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 8EA8D5963
 for <dev@dpdk.org>; Mon,  7 Sep 2015 09:57:28 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84) (envelope-from <olivier.matz@6wind.com>)
 id 1ZYrJ0-0001Em-Ik; Mon, 07 Sep 2015 09:57:35 +0200
Message-ID: <55ED4361.8050008@6wind.com>
Date: Mon, 07 Sep 2015 09:57:21 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version: 1.0
To: "Montorsi, Francesco" <fmontorsi@empirix.com>, 
 "dev@dpdk.org" <dev@dpdk.org>
References: <dbd2038b45054ab28775f311d2ccbd67@bilemail1.empirix.com>
In-Reply-To: <dbd2038b45054ab28775f311d2ccbd67@bilemail1.empirix.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] "cannot use T= with gcov target" when doing
 "makefile clean" with DPDK-2.1.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Sep 2015 07:57:28 -0000

Hi Francesco,

On 08/28/2015 11:06 AM, Montorsi, Francesco wrote:
> Hi all,
> 
> I found that after unzipping dpdk-2.1.0.tar.gz if I run:
>        # make T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc    config	
> And then
>     # make V=1 T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc    clean
> 
> I get:
> 
> [...]
> == Clean app/proc_info
> make -f /home/fmontorsi/Downloads/dpdk-2.1.0/GNUmakefile gcovclean
> make -f /home/fmontorsi/Downloads/dpdk-2.1.0/mk/rte.sdkgcov.mk gcovclean
> /home/fmontorsi/Downloads/dpdk-2.1.0/mk/rte.sdkgcov.mk:34: *** "Cannot use T= with gcov target".  Stop.
> make[2]: *** [gcovclean] Error 2
> make[1]: *** [clean] Error 2
> make: *** [clean] Error 2
> 	
> I guess the fix is:
> 
> --- /home/fmontorsi/Downloads/dpdk-2.1.0/mk/rte.sdkbuild.mk	2015-08-17 19:35:37.000000000 +0200
> +++ dpdk-2.1.0/mk/rte.sdkbuild.mk	2015-08-28 10:52:56.092466418 +0200
> @@ -85,5 +85,7 @@
>  	@$(RTE_SDK)/scripts/gen-config-h.sh $(RTE_OUTPUT)/.config \
>  		> $(RTE_OUTPUT)/include/rte_config.h
> +ifndef T
>  	$(Q)$(MAKE) -f $(RTE_SDK)/GNUmakefile gcovclean
> +endif
>  	@echo Clean complete
> 
> 
> Let me know if the patch above is wrong or I should do something else to contribute it to the project in the right way.

I had a look to your test case, I think the second command is not
correct. The T= parameter is not allowed for the clean target. It
should be something like this:

  # configure a workspace using template specified by T= in the
  # directory specified by O=
  make T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc config

  # clean the directory specified by O=
  make O=x86_64-native-linuxapp-gcc clean

See "make help" for details.


I think the proper patch would be to add the following lines on the
top of rte.sdkbuild.mk:

	ifdef T
	ifeq ("$(origin T)", "command line")
	$(error "Cannot use T= with a build/clean target")
	endif
	endif


It would then display the proper error message.
Can you have a try?

Regards,
Olivier