From: Ralf Hoffmann <ralf.hoffmann@allegro-packets.com>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] change hugepage sorting to avoid overlapping memcpy
Date: Wed, 9 Sep 2015 10:41:05 +0200 [thread overview]
Message-ID: <55EFF0A1.8050000@allegro-packets.com> (raw)
In-Reply-To: <55EED876.9050307@intel.com>
Hi Sergio,
On 08.09.2015 14:45, Gonzalez Monroy, Sergio wrote:
> Just a few comments/suggestions:
>
> Add 'eal/linux:' to the commit title, ie:
> "eal/linux: change hugepage sorting to avoid overlapping memcpy"
>
I would modify the patch according to your notes if needed, but if you
consider the other patch from Jay, then I would vote for that instead.
Actually, I thought about using qsort too, but decided against it to
keep the number of changes low and the sorting speed is not a problem
for me. Changing the return value of that function to void might still
be a good idea.
Best Regards,
Ralf
--
Ralf Hoffmann
Allegro Packets GmbH
Käthe-Kollwitz-Str. 54
04109 Leipzig
HRB 30535, Amtsgericht Leipzig
prev parent reply other threads:[~2015-09-09 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 10:14 Ralf Hoffmann
2015-09-08 12:45 ` Gonzalez Monroy, Sergio
2015-09-08 13:29 ` Jay Rolette
2015-09-08 14:24 ` Gonzalez Monroy, Sergio
2016-01-05 9:25 ` [dpdk-dev] [PATCH v2 0/1] " Ralf Hoffmann
2016-01-05 9:25 ` [dpdk-dev] [PATCH v2 1/1] " Ralf Hoffmann
2016-01-05 9:37 ` [dpdk-dev] [PATCH v3 0/1] eal/linux: " Ralf Hoffmann
2016-01-05 9:37 ` [dpdk-dev] [PATCH v3 1/1] " Ralf Hoffmann
2016-01-07 9:33 ` Sergio Gonzalez Monroy
2016-01-07 9:51 ` Sergio Gonzalez Monroy
2016-01-07 10:38 ` Sergio Gonzalez Monroy
2016-01-07 13:58 ` Ralf Hoffmann
2016-01-07 13:59 ` [dpdk-dev] [PATCH v4 1/1] " Ralf Hoffmann
2016-01-07 14:36 ` Sergio Gonzalez Monroy
2016-01-07 14:54 ` [dpdk-dev] [PATCH v5 1/1] eal/linux: " Ralf Hoffmann
2016-03-02 16:13 ` Thomas Monjalon
2015-09-09 8:41 ` Ralf Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EFF0A1.8050000@allegro-packets.com \
--to=ralf.hoffmann@allegro-packets.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).