From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay04.ispgateway.de (smtprelay04.ispgateway.de [80.67.31.27]) by dpdk.org (Postfix) with ESMTP id 9B9BA567F for ; Wed, 9 Sep 2015 10:41:06 +0200 (CEST) Received: from [87.172.168.38] (helo=[10.54.0.205]) by smtprelay04.ispgateway.de with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.84) (envelope-from ) id 1ZZawE-0002RX-HE; Wed, 09 Sep 2015 10:41:06 +0200 To: "Gonzalez Monroy, Sergio" References: <1441361677-10271-1-git-send-email-ralf.hoffmann@allegro-packets.com> <55EED876.9050307@intel.com> From: Ralf Hoffmann X-Enigmail-Draft-Status: N1110 Message-ID: <55EFF0A1.8050000@allegro-packets.com> Date: Wed, 9 Sep 2015 10:41:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55EED876.9050307@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Df-Sender: cmFsZi5ob2ZmbWFubkBhbGxlZ3JvLXBhY2tldHMuY29t Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1] change hugepage sorting to avoid overlapping memcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2015 08:41:06 -0000 Hi Sergio, On 08.09.2015 14:45, Gonzalez Monroy, Sergio wrote: > Just a few comments/suggestions: > > Add 'eal/linux:' to the commit title, ie: > "eal/linux: change hugepage sorting to avoid overlapping memcpy" > I would modify the patch according to your notes if needed, but if you consider the other patch from Jay, then I would vote for that instead. Actually, I thought about using qsort too, but decided against it to keep the number of changes low and the sorting speed is not a problem for me. Changing the return value of that function to void might still be a good idea. Best Regards, Ralf -- Ralf Hoffmann Allegro Packets GmbH Käthe-Kollwitz-Str. 54 04109 Leipzig HRB 30535, Amtsgericht Leipzig