Re: [PATCH v2 2/2] net/hns3: add FDIR VLAN match mode runtime config

[Dongdong Liu <liudongdong3@huawei.com>]

On 2023/6/29 19:08, Ferruh Yigit wrote:
> On 6/28/2023 3:59 AM, Dongdong Liu wrote:
>> Hi Thomas
>>
>> Many thanks for your review.
>>
>> On 2023/6/28 7:12, Thomas Monjalon wrote:
>>> 27/06/2023 09:11, Dongdong Liu:
>>>> +- ``fdir_vlan_match_mode`` (default `strict`)
>>>> +
>>>> +  Used to select VLAN match mode. This runtime config can be `strict`
>>>> +  or `nostrict` and is only valid for PF drives.
>>>
>>> drives? Do you mean devices?
>> for PF devices, will fix.
>>>
>>>> +  If driver works on `strict` mode (default mode), hardware does
>>>> strictly
>>>> +  match the input flow base on VLAN number.
>>>> +
>>>> +  For the following scenarios with two rules:
>>>> +
>>>> +  .. code-block:: console
>>>> +
>>>> +    rule0:
>>>> +      pattern: eth type is 0x0806
>>>> +      actions: queue index 3
>>>> +    rule1:
>>>> +      pattern: eth type is 0x0806 / vlan vid is 20
>>>> +      actions: queue index 4
>>>> +
>>>> +  If application select `strict` mode, only the ARP packets with VLAN
>>>> +  20 are directed to queue 4, and the ARP packets with other VLAN ID
>>>> +  cannot be directed to the specified queue. If application want to all
>>>> +  ARP packets with or without VLAN to be directed to the specified
>>>> queue,
>>>> +  application can select `nostrict` mode and just need to set rule0.
>>>
>>> As it is done in the rest of the document, you should use double
>>> backquotes
>>> for values of the devargs.
>> Good point, will fix.
>>
>
> I dropped set from next-net, please send a new version with fix.
> Updating patchwork status as "Change Requested".
PATCH V3 has been sent out, thanks for doing this.

Thanks,
Dongdong.

>
> .
>