From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5B45A0A05; Wed, 20 Jan 2021 16:24:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C042140D98; Wed, 20 Jan 2021 16:24:04 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id EF241140D67; Wed, 20 Jan 2021 16:24:02 +0100 (CET) IronPort-SDR: HqmdhKueej3gW3K3PQHnpzZIp3GhNvIOyCPaTKL/4b3ysEQwFrOuKFPDV4gnJL1rCSmFyXvnJU eOpKF0R158Cg== X-IronPort-AV: E=McAfee;i="6000,8403,9870"; a="263932915" X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="263932915" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 07:24:02 -0800 IronPort-SDR: JXmVGgH8Oaz+iv0x0dLVIimBCctfhwjQf4hAcH4cPgsf2HC/DirBXYw2N6vk59gdVz/2iOQk6L zSPDP3bIIfSw== X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="351084700" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.240.112]) ([10.213.240.112]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 07:24:00 -0800 To: David Hunt , dev@dpdk.org Cc: stable@dpdk.org, Bruce Richardson References: <20210108143048.23755-2-david.hunt@intel.com> <20210120135556.33763-1-david.hunt@intel.com> <20210120135556.33763-3-david.hunt@intel.com> <3e7fc5b8-9e10-af74-6060-68143a8931be@intel.com> <71a096fb-52d1-f08b-4e7d-c11e8f8c65c7@intel.com> From: "Burakov, Anatoly" Message-ID: <55b6af69-b464-6273-d37d-0b8809eba289@intel.com> Date: Wed, 20 Jan 2021 15:23:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <71a096fb-52d1-f08b-4e7d-c11e8f8c65c7@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 2/6] power: make channel msg functions public X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20-Jan-21 3:08 PM, David Hunt wrote: > > On 20/1/2021 2:26 PM, Burakov, Anatoly wrote: >> On 20-Jan-21 1:55 PM, David Hunt wrote: >>> From: Bruce Richardson >>> >>> Move the 2 public functions into rte_power_guest_channel.h >>> >>> Fixes: 210c383e247b ("power: packet format for vm power management") >>> Fixes: cd0d5547e873 ("power: vm communication channels in guest") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Bruce Richardson >>> Signed-off-by: David Hunt >>> >>> --- >> >> >> >>>   +/** >>> + * Send a message contained in pkt over the Virtio-Serial to the >>> host endpoint. >>> + * >>> + * @param pkt >>> + *  Pointer to a populated struct channel_packet >>> + * >>> + * @param lcore_id >>> + *  lcore_id. >> >> Not very informative doxygen comment :) > > > Maybe "Use channel specific to this lcore_id"? > Something like that, yes. Or, "Use channel associated with this lcore ID". -- Thanks, Anatoly