From: huangdengdui <huangdengdui@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Cc: <david.hunt@intel.com>, <anatoly.burakov@intel.com>,
<jerinj@marvell.com>, <radu.nicolau@intel.com>,
<gakhil@marvell.com>, <cristian.dumitrescu@intel.com>,
<Ferruh.Yigit@amd.com>, <konstantin.ananyev@huawei.com>,
<mb@smartsharesystems.com>, <dev@dpdk.org>,
Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
Subject: Re: [PATCH v2] examples/l3fwd: adjust Tx burst size based on Rx burst
Date: Tue, 10 Jun 2025 14:42:00 +0800 [thread overview]
Message-ID: <55beecec-89f9-43df-8eec-9e51bd72ed1c@huawei.com> (raw)
In-Reply-To: <20250609082154.489681e1@hermes.local>
On 2025/6/9 23:21, Stephen Hemminger wrote:
> On Mon, 9 Jun 2025 09:58:27 +0000
> Sivaprasad Tummala <sivaprasad.tummala@amd.com> wrote:
>
>> Previously, the TX burst size was fixed at 256, leading to performance
>> degradation in certain scenarios.
>>
>> This patch introduces logic to set the TX burst size to match the
>> configured RX burst size (--burst option, default 32, max 512)
>> for better efficiency.
>>
>> Fixes: d5c4897ecfb2 ("examples/l3fwd: add option to set Rx burst size")
>> Cc: haijie1@huawei.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
>> Tested-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
>> Tested-by: Dengdui Huang <huangdengdui@huawei.com>
>
> What driver? Why not fix the driver.
> If RX burst is small, there should be no way to get TX burst larger
> than that to happen.
If the Tx burst is too large, a number of mbufs will be temporarily stored in l3fwd's mbuf_table in a short period of time.
This leads to a decrease in the hit rate of the mempool cache, resulting in a drop in performance.
next prev parent reply other threads:[~2025-06-10 6:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 4:54 [PATCH] " Sivaprasad Tummala
2025-02-12 9:17 ` Ande, Venkat Kumar
2025-02-12 9:46 ` Ande, Venkat Kumar
2025-02-19 16:59 ` Konstantin Ananyev
2025-05-08 1:44 ` huangdengdui
2025-06-09 9:58 ` [PATCH v2] " Sivaprasad Tummala
2025-06-09 15:21 ` Stephen Hemminger
2025-06-10 6:42 ` huangdengdui [this message]
2025-06-10 7:57 ` fengchengwen
2025-06-10 14:29 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55beecec-89f9-43df-8eec-9e51bd72ed1c@huawei.com \
--to=huangdengdui@huawei.com \
--cc=Ferruh.Yigit@amd.com \
--cc=VenkatKumar.Ande@amd.com \
--cc=anatoly.burakov@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=radu.nicolau@intel.com \
--cc=sivaprasad.tummala@amd.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).