From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E6B8836E for ; Mon, 19 Dec 2016 15:49:31 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 19 Dec 2016 06:49:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,374,1477983600"; d="scan'208";a="44728756" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by fmsmga006.fm.intel.com with ESMTP; 19 Dec 2016 06:49:30 -0800 To: Alejandro Lucero , dev@dpdk.org References: <1482148887-40708-1-git-send-email-alejandro.lucero@netronome.com> From: Ferruh Yigit Message-ID: <55e06c6c-e928-5b56-5d6e-2e9c0f5cb1e4@intel.com> Date: Mon, 19 Dec 2016 14:49:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1482148887-40708-1-git-send-email-alejandro.lucero@netronome.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] nfp: report link speed using hardware info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 14:49:32 -0000 On 12/19/2016 12:01 PM, Alejandro Lucero wrote: > Previous reported speed was hardcoded because there was not firmware > support for getting this information. This change needs to support old > firmware versions, keeping with the hardcoded report, and the new > versions, where the firmware makes that information available. > > v5: Fix missing parenthesis > v4: Make conditional simple and more ellaborated commit comment. > v3: remove unsed macro > v2: use RTE_DIM instead of own macro > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.