From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 8FDCA8D94
 for <dev@dpdk.org>; Tue, 22 Sep 2015 09:46:45 +0200 (CEST)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
 (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
 by mx1.redhat.com (Postfix) with ESMTPS id C7BAA8EA23;
 Tue, 22 Sep 2015 07:46:44 +0000 (UTC)
Received: from dhcp195.koti.laiskiainen.org (vpn1-6-117.ams2.redhat.com
 [10.36.6.117])
 by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 t8M7khZ4013579; Tue, 22 Sep 2015 03:46:44 -0400
To: Mario Carrillo <mario.alfredo.c.arevalo@intel.com>, dev@dpdk.org
References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com>
 <1442608390-12537-7-git-send-email-mario.alfredo.c.arevalo@intel.com>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <56010763.1080006@redhat.com>
Date: Tue, 22 Sep 2015 10:46:43 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1442608390-12537-7-git-send-email-mario.alfredo.c.arevalo@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
Subject: Re: [dpdk-dev] [PATCH 6/7] mk: Add hierarchy-file support (lib)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2015 07:46:45 -0000

On 09/18/2015 11:33 PM, Mario Carrillo wrote:
> Add hierarchy-file support to the DPDK libs,
> when invoking "make install H=1" (hierarchy-file)
>
> This hierarchy is based on:
> http://www.freedesktop.org/software/systemd/man/file-hierarchy.html
>
> for this case, if the architecture is 64 bits libs will be
> instaled in: $(DESTDIR)/usr/lib64 else it will be $(DESTDIR)/usr/lib
>
> Signed-off-by: Mario Carrillo <mario.alfredo.c.arevalo@intel.com>
> ---
[...]
> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
> index 723fd97..b506959 100644
> --- a/mk/rte.sdkinstall.mk
> +++ b/mk/rte.sdkinstall.mk
> @@ -59,9 +59,15 @@ DATA_DIR := $(DESTDIR)/usr/share
>   INCLUDE_DIR := $(DESTDIR)/usr/include
>   SBIN_DIR := $(DESTDIR)/usr/sbin
>   BIN_DIR := $(DESTDIR)/usr/bin
> +ifeq ($(RTE_ARCH),x86_64)
> +LIB_DIR := $(DESTDIR)/usr/lib64
> +else
> +LIB_DIR := $(DESTDIR)/usr/lib
> +endif

While this would sort of work, for now, for Fedora, RHEL and derivates, 
it is incorrect for the Debian world. It also misses ppc64 for which we 
have a config file in the tree (whether it actually builds I dont know).

The location of libdir is essentially a distro level choice, upstream 
projects are better off with a predictable default (say, /usr/lib) that 
is easy to override during build/install.

One possibility could be using systemd-path (if present) for querying 
the distro settings, eg

$ systemd-path system-library-arch
/usr/lib64

	- Panu -