From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 25BB0234 for ; Tue, 22 Sep 2015 10:00:29 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1ZeIVB-00079b-5W; Tue, 22 Sep 2015 10:00:40 +0200 Message-ID: <56010A91.5020607@6wind.com> Date: Tue, 22 Sep 2015 10:00:17 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Panu Matilainen , Mario Carrillo , dev@dpdk.org References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <5600F549.20000@redhat.com> In-Reply-To: <5600F549.20000@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/7] Add hierarchical support to make install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2015 08:00:29 -0000 Hi, On 09/22/2015 08:29 AM, Panu Matilainen wrote: > On 09/18/2015 11:33 PM, Mario Carrillo wrote: >> DPDK package lacks of a mechanism to install libraries, headers >> applications and kernel modules to a file system tree. >> >> This patch set allows to install files according to the next >> proposal: >> http://www.freedesktop.org/software/systemd/man/file-hierarchy.html >> >> By adding a parameter H=1 (hierarchy-file) to makefile system, it is >> possible to do the next steps >> >> make config T=TARGET >> make >> make install H=1 >> >> and files will be installed on the proper directory. Also you can use >> the DESTDIR variable. > > Thanks for working on this! > > My 5c is that I'd rather see "make install" do the right thing (as in, > behave like a normal OSS project) by default instead of requiring some > obscure additional parameter (which almost nobody will then find) to > activate it. Actually, the current "install" directive means: install all stuff required to build a project for the specified targets (example: x86_64-native-linuxapp-gcc). If we just do "make install T=${target}", the target is installed into the current SDK source. Adding DESTDIR will install the binary DPDK in a new directory. Example: make -j32 T="*-native-linuxapp-gcc" DESTDIR=/tmp/binary-dpdk install In both cases, the result can be used to build an application (like the one found in examples) using the the DPDK framework. So, the current "install" directive should be understood as "install binary sdk". >>From what I understand, what Mario wants to add is a "install runtime libraries" directive. I agree that using H=1 is maybe not the clearest solution. What about renaming the "install" directive to: - install-sdk - install-runtime It would help to keep the current behavior of "install" for some time, marking it as deprecated. Regards, Olivier