DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "huzaifa.rahman" <huzaifa.rahman@emumba.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] docs: change the doc to highlight the allowed multicast addresses
Date: Fri, 31 Mar 2023 12:23:20 +0200	[thread overview]
Message-ID: <5602947.usQuhbGJ8B@thomas> (raw)
In-Reply-To: <20220701103726.4190485-1-huzaifa.rahman@emumba.com>

01/07/2022 12:37, huzaifa.rahman:
> Bugzilla ID: 802
> 
> The ipv4_multicast example does not work with any multicast IPs.
> Only a selected few IPs are allowed to send pakcets. These IPs
> are listed in an mcast_group_table array along with their respective
> port masks. A normal user would not know about this behaviour since
> there is no mention of it in the docs
> 
> Added the mcast_group_table in the docs so user would know which
> IPs are allowed.
> 
> Signed-off-by: huzaifa.rahman <huzaifa.rahman@emumba.com>
> ---
> +.. literalinclude:: ../../../examples/ipv4_multicast/main.c
> +    :language: c
> +    :start-after: Create the mcast group table. 8<
> +    :end-before: >8 End of create mcast group table.

No need to add artificial comments. The following works fine:
	:start-after: mcast_group_table
	:end-before: };

Applied with above simplification, thanks.



      parent reply	other threads:[~2023-03-31 10:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01 10:37 huzaifa.rahman
2022-08-11  3:48 ` Huzaifa Rahman
2023-03-31 10:23 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5602947.usQuhbGJ8B@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=huzaifa.rahman@emumba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).