[dpdk-dev] [PATCH 0/3] Minor abi-validator improvements

DPDK patches and discussions
 help / color / mirror / Atom feed

* [dpdk-dev] [PATCH 0/3] Minor abi-validator improvements
@ 2015-09-24  7:34 Panu Matilainen
  2015-09-24  7:34 ` [dpdk-dev] [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator Panu Matilainen
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Panu Matilainen @ 2015-09-24  7:34 UTC (permalink / raw)
  To: dev

For giggles, tried running abi-validator between 2.0 and 2.1 on
my Fedora 22 laptop, didn't work due to various build failures.
With this patch series the following now succeeds:

EXTRA_CFLAGS="-Wno-error" scripts/validate-abi.sh v2.0.0 v2.1.0 x86_64-native-linuxapp-gcc

Panu Matilainen (3):
  scripts: permit passing extra compiler & linker flags to ABI validator
  scripts: move two identical config fixups into a function
  scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD

 scripts/validate-abi.sh | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

-- 
2.4.3

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator
  2015-09-24  7:34 [dpdk-dev] [PATCH 0/3] Minor abi-validator improvements Panu Matilainen
@ 2015-09-24  7:34 ` Panu Matilainen
  2015-09-24  7:34 ` [dpdk-dev] [PATCH 2/3] scripts: move two identical config fixups into a function Panu Matilainen
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 14+ messages in thread
From: Panu Matilainen @ 2015-09-24  7:34 UTC (permalink / raw)
  To: dev

Its sometimes necessary to disable warnings etc to get an older
version of code to build.

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 scripts/validate-abi.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh
index 4476433..b9c9989 100755
--- a/scripts/validate-abi.sh
+++ b/scripts/validate-abi.sh
@@ -164,8 +164,8 @@ sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
 # Checking abi compliance relies on using the dwarf information in
 # The shared objects.  Thats only included in the DSO's if we build
 # with -g
-export EXTRA_CFLAGS=-g
-export EXTRA_LDFLAGS=-g
+export EXTRA_CFLAGS="$EXTRA_CFLAGS -g"
+export EXTRA_LDFLAGS="$EXTRA_LDFLAGS -g"
 
 # Now configure the build
 log "INFO" "Configuring DPDK $TAG1"
-- 
2.4.3

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 2/3] scripts: move two identical config fixups into a function
  2015-09-24  7:34 [dpdk-dev] [PATCH 0/3] Minor abi-validator improvements Panu Matilainen
  2015-09-24  7:34 ` [dpdk-dev] [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator Panu Matilainen
@ 2015-09-24  7:34 ` Panu Matilainen
  2015-09-24  7:42   ` Panu Matilainen
  2015-09-24  7:34 ` [dpdk-dev] [PATCH 3/3] scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD Panu Matilainen
  2015-09-24  7:50 ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Panu Matilainen
  3 siblings, 1 reply; 14+ messages in thread
From: Panu Matilainen @ 2015-09-24  7:34 UTC (permalink / raw)
  To: dev

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 scripts/validate-abi.sh | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh
index b9c9989..4b555de 100755
--- a/scripts/validate-abi.sh
+++ b/scripts/validate-abi.sh
@@ -81,6 +81,15 @@ cleanup_and_exit() {
 	exit $1
 }
 
+# Make sure we configure SHARED libraries
+# Also turn off IGB and KNI as those require kernel headers to build
+fixup_config() {
+	sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET
+	sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET
+	sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET
+	sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
+}
+
 ###########################################
 #START
 ############################################
@@ -154,12 +163,7 @@ log "INFO" "Checking out version $TAG1 of the dpdk"
 # Move to the old version of the tree
 git checkout $TAG1
 
-# Make sure we configure SHARED libraries
-# Also turn off IGB and KNI as those require kernel headers to build
-sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
+fixup_config
 
 # Checking abi compliance relies on using the dwarf information in
 # The shared objects.  Thats only included in the DSO's if we build
@@ -167,6 +171,8 @@ sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
 export EXTRA_CFLAGS="$EXTRA_CFLAGS -g"
 export EXTRA_LDFLAGS="$EXTRA_LDFLAGS -g"
 
+fixup_config
+
 # Now configure the build
 log "INFO" "Configuring DPDK $TAG1"
 make config T=$TARGET O=$TARGET > $VERBOSE 2>&1
@@ -196,13 +202,6 @@ git reset --hard
 log "INFO" "Checking out version $TAG2 of the dpdk"
 git checkout $TAG2
 
-# Make sure we configure SHARED libraries
-# Also turn off IGB and KNI as those require kernel headers to build
-sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
-
 # Now configure the build
 log "INFO" "Configuring DPDK $TAG2"
 make config T=$TARGET O=$TARGET > $VERBOSE 2>&1
-- 
2.4.3

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 2/3] scripts: move two identical config fixups into a function
  2015-09-24  7:34 ` [dpdk-dev] [PATCH 2/3] scripts: move two identical config fixups into a function Panu Matilainen
@ 2015-09-24  7:42   ` Panu Matilainen
  0 siblings, 0 replies; 14+ messages in thread
From: Panu Matilainen @ 2015-09-24  7:42 UTC (permalink / raw)
  To: dev

On 09/24/2015 10:34 AM, Panu Matilainen wrote:

>   # Checking abi compliance relies on using the dwarf information in
>   # The shared objects.  Thats only included in the DSO's if we build
> @@ -167,6 +171,8 @@ sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
>   export EXTRA_CFLAGS="$EXTRA_CFLAGS -g"
>   export EXTRA_LDFLAGS="$EXTRA_LDFLAGS -g"
>
> +fixup_config
> +
>   # Now configure the build
>   log "INFO" "Configuring DPDK $TAG1"
>   make config T=$TARGET O=$TARGET > $VERBOSE 2>&1
> @@ -196,13 +202,6 @@ git reset --hard
>   log "INFO" "Checking out version $TAG2 of the dpdk"
>   git checkout $TAG2
>
> -# Make sure we configure SHARED libraries
> -# Also turn off IGB and KNI as those require kernel headers to build
> -sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET
> -sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET
> -sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET
> -sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
> -

Doh. Obvious brain damage here, will send v2 after fetching apparently 
needed additional coffee.

	- Panu -

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 3/3] scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD
  2015-09-24  7:34 [dpdk-dev] [PATCH 0/3] Minor abi-validator improvements Panu Matilainen
  2015-09-24  7:34 ` [dpdk-dev] [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator Panu Matilainen
  2015-09-24  7:34 ` [dpdk-dev] [PATCH 2/3] scripts: move two identical config fixups into a function Panu Matilainen
@ 2015-09-24  7:34 ` Panu Matilainen
  2015-09-24  7:50 ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Panu Matilainen
  3 siblings, 0 replies; 14+ messages in thread
From: Panu Matilainen @ 2015-09-24  7:34 UTC (permalink / raw)
  To: dev

The validator attempts to disable all kernel modules but since
commit 36080ff96b0eb37a6da8c4fec1a2f8a57dfadf5b fails to do so
for KNI, causing the build stage to fail if kernel headers are missing.

With the introduction of CONFIG_RTE_KNI_KMOD, CONFIG_RTE_LIBRTE_KNI=n
can eventually be dropped but leaving it around for now as its
needed with pre-2.1 versions.

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 scripts/validate-abi.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh
index 4b555de..6be67d0 100755
--- a/scripts/validate-abi.sh
+++ b/scripts/validate-abi.sh
@@ -88,6 +88,7 @@ fixup_config() {
 	sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET
 	sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET
 	sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
+	sed -i -e"$ a\CONFIG_RTE_KNI_KMOD=n" config/defconfig_$TARGET
 }
 
 ###########################################
-- 
2.4.3

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements
  2015-09-24  7:34 [dpdk-dev] [PATCH 0/3] Minor abi-validator improvements Panu Matilainen
                   ` (2 preceding siblings ...)
  2015-09-24  7:34 ` [dpdk-dev] [PATCH 3/3] scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD Panu Matilainen
@ 2015-09-24  7:50 ` Panu Matilainen
  2015-09-24  7:50   ` [dpdk-dev] [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator Panu Matilainen
                     ` (3 more replies)
  3 siblings, 4 replies; 14+ messages in thread
From: Panu Matilainen @ 2015-09-24  7:50 UTC (permalink / raw)
  To: dev

For giggles, tried running abi-validator between 2.0 and 2.1 on
my Fedora 22 laptop, didn't work due to various build failures.
With this patch series the following now succeeds:

EXTRA_CFLAGS="-Wno-error" scripts/validate-abi.sh v2.0.0 v2.1.0 x86_64-native-linuxapp-gcc

Panu Matilainen (3):
  scripts: permit passing extra compiler & linker flags to ABI validator
  scripts: move two identical config fixups into a function
  scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD

 scripts/validate-abi.sh | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

-- 
2.4.3

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator
  2015-09-24  7:50 ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Panu Matilainen
@ 2015-09-24  7:50   ` Panu Matilainen
  2015-09-24  7:50   ` [dpdk-dev] [PATCH 2/3] scripts: move two identical config fixups into a function Panu Matilainen
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 14+ messages in thread
From: Panu Matilainen @ 2015-09-24  7:50 UTC (permalink / raw)
  To: dev

Its sometimes necessary to disable warnings etc to get an older
version of code to build.

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 scripts/validate-abi.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh
index 4476433..b9c9989 100755
--- a/scripts/validate-abi.sh
+++ b/scripts/validate-abi.sh
@@ -164,8 +164,8 @@ sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
 # Checking abi compliance relies on using the dwarf information in
 # The shared objects.  Thats only included in the DSO's if we build
 # with -g
-export EXTRA_CFLAGS=-g
-export EXTRA_LDFLAGS=-g
+export EXTRA_CFLAGS="$EXTRA_CFLAGS -g"
+export EXTRA_LDFLAGS="$EXTRA_LDFLAGS -g"
 
 # Now configure the build
 log "INFO" "Configuring DPDK $TAG1"
-- 
2.4.3

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 2/3] scripts: move two identical config fixups into a function
  2015-09-24  7:50 ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Panu Matilainen
  2015-09-24  7:50   ` [dpdk-dev] [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator Panu Matilainen
@ 2015-09-24  7:50   ` Panu Matilainen
  2015-09-24  7:50   ` [dpdk-dev] [PATCH 3/3] scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD Panu Matilainen
  2015-09-24 10:23   ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Neil Horman
  3 siblings, 0 replies; 14+ messages in thread
From: Panu Matilainen @ 2015-09-24  7:50 UTC (permalink / raw)
  To: dev

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 scripts/validate-abi.sh | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh
index b9c9989..12946d4 100755
--- a/scripts/validate-abi.sh
+++ b/scripts/validate-abi.sh
@@ -81,6 +81,15 @@ cleanup_and_exit() {
 	exit $1
 }
 
+# Make sure we configure SHARED libraries
+# Also turn off IGB and KNI as those require kernel headers to build
+fixup_config() {
+	sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET
+	sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET
+	sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET
+	sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
+}
+
 ###########################################
 #START
 ############################################
@@ -154,12 +163,7 @@ log "INFO" "Checking out version $TAG1 of the dpdk"
 # Move to the old version of the tree
 git checkout $TAG1
 
-# Make sure we configure SHARED libraries
-# Also turn off IGB and KNI as those require kernel headers to build
-sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
+fixup_config
 
 # Checking abi compliance relies on using the dwarf information in
 # The shared objects.  Thats only included in the DSO's if we build
@@ -196,12 +200,7 @@ git reset --hard
 log "INFO" "Checking out version $TAG2 of the dpdk"
 git checkout $TAG2
 
-# Make sure we configure SHARED libraries
-# Also turn off IGB and KNI as those require kernel headers to build
-sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET
-sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
+fixup_config
 
 # Now configure the build
 log "INFO" "Configuring DPDK $TAG2"
-- 
2.4.3

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 3/3] scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD
  2015-09-24  7:50 ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Panu Matilainen
  2015-09-24  7:50   ` [dpdk-dev] [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator Panu Matilainen
  2015-09-24  7:50   ` [dpdk-dev] [PATCH 2/3] scripts: move two identical config fixups into a function Panu Matilainen
@ 2015-09-24  7:50   ` Panu Matilainen
  2015-09-24 10:23   ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Neil Horman
  3 siblings, 0 replies; 14+ messages in thread
From: Panu Matilainen @ 2015-09-24  7:50 UTC (permalink / raw)
  To: dev

The validator attempts to disable all kernel modules but since
commit 36080ff96b0eb37a6da8c4fec1a2f8a57dfadf5b fails to do so
for KNI, causing the build stage to fail if kernel headers are missing.

With the introduction of CONFIG_RTE_KNI_KMOD, CONFIG_RTE_LIBRTE_KNI=n
can eventually be dropped but leaving it around for now as its
needed with pre-2.1 versions.

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 scripts/validate-abi.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh
index 12946d4..cbf9d7f 100755
--- a/scripts/validate-abi.sh
+++ b/scripts/validate-abi.sh
@@ -88,6 +88,7 @@ fixup_config() {
 	sed -i -e"$ a\CONFIG_RTE_NEXT_ABI=n" config/defconfig_$TARGET
 	sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET
 	sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET
+	sed -i -e"$ a\CONFIG_RTE_KNI_KMOD=n" config/defconfig_$TARGET
 }
 
 ###########################################
-- 
2.4.3

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements
  2015-09-24  7:50 ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Panu Matilainen
                     ` (2 preceding siblings ...)
  2015-09-24  7:50   ` [dpdk-dev] [PATCH 3/3] scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD Panu Matilainen
@ 2015-09-24 10:23   ` Neil Horman
  2015-11-11  7:07     ` Panu Matilainen
  2015-12-03 19:38     ` Thomas Monjalon
  3 siblings, 2 replies; 14+ messages in thread
From: Neil Horman @ 2015-09-24 10:23 UTC (permalink / raw)
  To: Panu Matilainen; +Cc: dev

On Thu, Sep 24, 2015 at 10:50:56AM +0300, Panu Matilainen wrote:
> For giggles, tried running abi-validator between 2.0 and 2.1 on
> my Fedora 22 laptop, didn't work due to various build failures.
> With this patch series the following now succeeds:
> 
> EXTRA_CFLAGS="-Wno-error" scripts/validate-abi.sh v2.0.0 v2.1.0 x86_64-native-linuxapp-gcc
> 
> Panu Matilainen (3):
>   scripts: permit passing extra compiler & linker flags to ABI validator
>   scripts: move two identical config fixups into a function
>   scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD
> 
>  scripts/validate-abi.sh | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> -- 
> 2.4.3
> 
> 

series
Acked-by: Neil Horman <nhorman@tuxdriver.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements
  2015-09-24 10:23   ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Neil Horman
@ 2015-11-11  7:07     ` Panu Matilainen
  2015-11-11 10:16       ` Thomas Monjalon
  2015-12-03 19:38     ` Thomas Monjalon
  1 sibling, 1 reply; 14+ messages in thread
From: Panu Matilainen @ 2015-11-11  7:07 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On 09/24/2015 01:23 PM, Neil Horman wrote:
> On Thu, Sep 24, 2015 at 10:50:56AM +0300, Panu Matilainen wrote:
>> For giggles, tried running abi-validator between 2.0 and 2.1 on
>> my Fedora 22 laptop, didn't work due to various build failures.
>> With this patch series the following now succeeds:
>>
>> EXTRA_CFLAGS="-Wno-error" scripts/validate-abi.sh v2.0.0 v2.1.0 x86_64-native-linuxapp-gcc
>>
>> Panu Matilainen (3):
>>    scripts: permit passing extra compiler & linker flags to ABI validator
>>    scripts: move two identical config fixups into a function
>>    scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD
>>
>>   scripts/validate-abi.sh | 28 ++++++++++++++--------------
>>   1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> --
>> 2.4.3
>>
>>
>
> series
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Thomas, any particular reason this hasn't been applied yet?

	- Panu -

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements
  2015-11-11  7:07     ` Panu Matilainen
@ 2015-11-11 10:16       ` Thomas Monjalon
  2015-11-11 10:24         ` Panu Matilainen
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Monjalon @ 2015-11-11 10:16 UTC (permalink / raw)
  To: Panu Matilainen; +Cc: dev

2015-11-11 09:07, Panu Matilainen:
> On 09/24/2015 01:23 PM, Neil Horman wrote:
> > On Thu, Sep 24, 2015 at 10:50:56AM +0300, Panu Matilainen wrote:
> >> For giggles, tried running abi-validator between 2.0 and 2.1 on
> >> my Fedora 22 laptop, didn't work due to various build failures.
> >> With this patch series the following now succeeds:
> >>
> >> EXTRA_CFLAGS="-Wno-error" scripts/validate-abi.sh v2.0.0 v2.1.0 x86_64-native-linuxapp-gcc
> >>
> >> Panu Matilainen (3):
> >>    scripts: permit passing extra compiler & linker flags to ABI validator
> >>    scripts: move two identical config fixups into a function
> >>    scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD
> >>
> >>   scripts/validate-abi.sh | 28 ++++++++++++++--------------
> >>   1 file changed, 14 insertions(+), 14 deletions(-)
> >>
> >> --
> >> 2.4.3
> >>
> >>
> >
> > series
> > Acked-by: Neil Horman <nhorman@tuxdriver.com>
> 
> Thomas, any particular reason this hasn't been applied yet?

It was not the priority until now. I was busy with the drivers.
For next release, the integration should be easier because Bruce
will help with a drivers tree.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements
  2015-11-11 10:16       ` Thomas Monjalon
@ 2015-11-11 10:24         ` Panu Matilainen
  0 siblings, 0 replies; 14+ messages in thread
From: Panu Matilainen @ 2015-11-11 10:24 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On 11/11/2015 12:16 PM, Thomas Monjalon wrote:
> 2015-11-11 09:07, Panu Matilainen:
>> On 09/24/2015 01:23 PM, Neil Horman wrote:
>>> On Thu, Sep 24, 2015 at 10:50:56AM +0300, Panu Matilainen wrote:
>>>> For giggles, tried running abi-validator between 2.0 and 2.1 on
>>>> my Fedora 22 laptop, didn't work due to various build failures.
>>>> With this patch series the following now succeeds:
>>>>
>>>> EXTRA_CFLAGS="-Wno-error" scripts/validate-abi.sh v2.0.0 v2.1.0 x86_64-native-linuxapp-gcc
>>>>
>>>> Panu Matilainen (3):
>>>>     scripts: permit passing extra compiler & linker flags to ABI validator
>>>>     scripts: move two identical config fixups into a function
>>>>     scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD
>>>>
>>>>    scripts/validate-abi.sh | 28 ++++++++++++++--------------
>>>>    1 file changed, 14 insertions(+), 14 deletions(-)
>>>>
>>>> --
>>>> 2.4.3
>>>>
>>>>
>>>
>>> series
>>> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>>
>> Thomas, any particular reason this hasn't been applied yet?
>
> It was not the priority until now. I was busy with the drivers.
> For next release, the integration should be easier because Bruce
> will help with a drivers tree.
>

Understood, no worries. Just checking it hasn't fallen through the 
cracks due to some submission error on my behalf or something.

	- Panu -

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements
  2015-09-24 10:23   ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Neil Horman
  2015-11-11  7:07     ` Panu Matilainen
@ 2015-12-03 19:38     ` Thomas Monjalon
  1 sibling, 0 replies; 14+ messages in thread
From: Thomas Monjalon @ 2015-12-03 19:38 UTC (permalink / raw)
  To: Panu Matilainen; +Cc: dev

2015-09-24 06:23, Neil Horman:
> On Thu, Sep 24, 2015 at 10:50:56AM +0300, Panu Matilainen wrote:
> > For giggles, tried running abi-validator between 2.0 and 2.1 on
> > my Fedora 22 laptop, didn't work due to various build failures.
> > With this patch series the following now succeeds:
> > 
> > EXTRA_CFLAGS="-Wno-error" scripts/validate-abi.sh v2.0.0 v2.1.0 x86_64-native-linuxapp-gcc
> > 
> > Panu Matilainen (3):
> >   scripts: permit passing extra compiler & linker flags to ABI validator
> >   scripts: move two identical config fixups into a function
> >   scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD
> > 
> >  scripts/validate-abi.sh | 28 ++++++++++++++--------------
> >  1 file changed, 14 insertions(+), 14 deletions(-)
> > 
> 
> series
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2015-12-03 19:39 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-24  7:34 [dpdk-dev] [PATCH 0/3] Minor abi-validator improvements Panu Matilainen
2015-09-24  7:34 ` [dpdk-dev] [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator Panu Matilainen
2015-09-24  7:34 ` [dpdk-dev] [PATCH 2/3] scripts: move two identical config fixups into a function Panu Matilainen
2015-09-24  7:42   ` Panu Matilainen
2015-09-24  7:34 ` [dpdk-dev] [PATCH 3/3] scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD Panu Matilainen
2015-09-24  7:50 ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Panu Matilainen
2015-09-24  7:50   ` [dpdk-dev] [PATCH 1/3] scripts: permit passing extra compiler & linker flags to ABI validator Panu Matilainen
2015-09-24  7:50   ` [dpdk-dev] [PATCH 2/3] scripts: move two identical config fixups into a function Panu Matilainen
2015-09-24  7:50   ` [dpdk-dev] [PATCH 3/3] scripts: teach ABI validator about CONFIG_RTE_KNI_KMOD Panu Matilainen
2015-09-24 10:23   ` [dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements Neil Horman
2015-11-11  7:07     ` Panu Matilainen
2015-11-11 10:16       ` Thomas Monjalon
2015-11-11 10:24         ` Panu Matilainen
2015-12-03 19:38     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).